Page MenuHomeFreeBSD
Differential D4096

Always check the return value of lseek
ClosedPublic
Actions

Authored by asomers on Nov 6 2015, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 4:37 PM
Unknown Object (File)
Thu, Dec 5, 6:19 PM
Unknown Object (File)
Nov 29 2024, 7:06 AM
Unknown Object (File)
Nov 24 2024, 1:17 AM
Unknown Object (File)
Nov 1 2024, 6:27 PM
Unknown Object (File)
Nov 1 2024, 6:27 PM
Unknown Object (File)
Nov 1 2024, 6:27 PM
Unknown Object (File)
Nov 1 2024, 6:11 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
Commits
rS290463: Always check the return value of lseek.
Summary

Always check the return value of lseek. This is a follow-up to r289845, which
only fixed one occurence of CID 1009429.

Test Plan

Manually exercise savecore with each of the command line options.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1054
Build 1057: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 9996.Nov 6 2015, 5:24 PM
asomers retitled this revision from to Always check the return value of lseek.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: markj.
Herald added a subscriber: imp. · View Herald TranscriptNov 6 2015, 5:24 PM
markj accepted this revision.Nov 6 2015, 7:01 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2015, 7:01 PM
Closed by commit rS290463: Always check the return value of lseek. (authored by asomers). · Explain WhyNov 6 2015, 7:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
savecore/
10 lines

Diff 9996

View Options

sbin/savecore/savecore.c

Loading...