Page MenuHomeFreeBSD
Differential D4090

mbuf(9): unbreak m_fragment()
ClosedPublic
Actions

Authored by avos on Nov 5 2015, 10:29 PM.
Tags
None
Referenced Files
F137293127: D4090.id34038.vs9973.diff
Sat, Nov 22, 3:34 AM
Unknown Object (File)
Fri, Nov 21, 1:54 AM
Unknown Object (File)
Fri, Nov 21, 1:50 AM
Unknown Object (File)
Fri, Nov 21, 1:47 AM
Unknown Object (File)
Fri, Nov 21, 1:46 AM
Unknown Object (File)
Sun, Nov 16, 3:48 PM
Unknown Object (File)
Sat, Nov 15, 10:15 PM
Unknown Object (File)
Thu, Oct 30, 6:39 PM
View All Files
Subscribers
imp

Details

Reviewers
freebsd-net-list
glebius
adrian
Commits
rS331847: MFC r324673:
rS324673: mbuf(9): unbreak m_fragment()
Summary
  • Fix it by replacing m_cat() with m_prev->m_next = m_new;

(m_cat() will try to append data - as a result, now this function does nothing).

  • Move constants out of the loop.
Test Plan

Tested with D4077 (+ some output)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9973.Nov 5 2015, 10:29 PM
avos retitled this revision from to mbuf(9): unbreak m_fragment().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: adrian, glebius.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptNov 5 2015, 10:29 PM
adrian added a reviewer: freebsd-net-list.Jan 22 2016, 8:21 PM
Closed by commit rS324673: mbuf(9): unbreak m_fragment() (authored by avos). · Explain WhyOct 16 2017, 9:46 PM
This revision was automatically updated to reflect the committed changes.
Diffusion mentioned this in rS331847: MFC r324673:.Mar 31 2018, 5:28 PM

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
57 lines

Diff 34038

View Options

head/sys/kern/uipc_mbuf.c

Loading...