Page MenuHomeFreeBSD

net80211: try to move m_defrag() / m_collapse() to the ieee80211_mbuf_adjust()
Needs RevisionPublic

Authored by avos on Nov 3 2015, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 7:00 AM
Unknown Object (File)
Dec 20 2023, 12:26 AM
Unknown Object (File)
Aug 26 2023, 3:05 AM
Unknown Object (File)
Aug 10 2023, 9:38 PM
Unknown Object (File)
Jul 16 2023, 11:49 AM
Unknown Object (File)
Jun 6 2023, 1:37 PM
Unknown Object (File)
Apr 8 2023, 9:01 PM
Unknown Object (File)
Mar 23 2023, 6:23 AM
Subscribers

Details

Reviewers
adrian
Summary

Execute m_defrag() (or m_collapse(), depends on ic_seglimit variable) before submitting mbuf to the driver level. This should simplify error paths and remove two last stages from bus_dmamap_load_mbuf_sg() -(error)> m_collapse() -> bus_dmamap_load_mbuf_sg() sequence.

P.S. should it be added to the ieee80211_raw_output() too?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos retitled this revision from to net80211: try to move m_defrag() / m_collapse() to the ieee80211_mbuf_adjust().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
adrian requested changes to this revision.Nov 4 2015, 8:40 PM
adrian edited edge metadata.

Nah, we can't go down this path right now.

The problem with this is figuring out what to do when (eg crypto, realign things, etc) shouldn't be in net80211. We may want to do this at a much later stage when we've tidied up the existing drivers quite a bit more; I don't want to keep churning things without finishing all the current changes we're making.

So I'm going to leave this open so we at least have it in here to look at, but I don't want to commit this to -HEAD.

Thanks though!

This revision now requires changes to proceed.Nov 4 2015, 8:40 PM