radix_trie: pass fewer params to node_get
ClosedPublic
Actions

Authored by dougm on Jun 23 2023, 8:50 AM.

Tags

None

Referenced Files

	F154960876: D40723.id.diff
	Thu, Apr 30, 8:18 AM

	Unknown Object (File)
	Wed, Apr 29, 9:27 AM

	Unknown Object (File)
	Wed, Apr 29, 9:21 AM

	Unknown Object (File)
	Wed, Apr 22, 8:42 AM

	Unknown Object (File)
	Thu, Apr 16, 9:54 AM

	Unknown Object (File)
	Mon, Apr 13, 1:48 PM

	Unknown Object (File)
	Sun, Apr 12, 9:54 PM

	Unknown Object (File)
	Sat, Apr 11, 1:32 AM

View All Files

Subscribers

imp

Details

Reviewers

alc
markj

Commits

rGda72505f9c6a: radix_trie: pass fewer params to node_get

Summary

Let node_get calculate it's own owner value. Don't pass the count parameter, since it's always 2. Save 16 bytes in insert(). Move, without modifying, slot and trimkey to handle use-before-declaration problem.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 23 2023, 8:50 AM

dougm created this revision.

This patch needs a refresh after the trimkey patch.

markj accepted this revision.Jun 27 2023, 2:00 PM

markj added inline comments.

sys/kern/subr_pctrie.c
101	Perhaps remove the extra newline here since you're moving this function anyway.

This revision is now accepted and ready to land.Jun 27 2023, 2:00 PM

Closed by commit rGda72505f9c6a: radix_trie: pass fewer params to node_get (authored by dougm). · Explain WhyJun 27 2023, 5:22 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGda72505f9c6a: radix_trie: pass fewer params to node_get.

Herald added a subscriber: imp. · View Herald TranscriptJun 27 2023, 5:22 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_pctrie.c

47 lines

vm/

vm_radix.c

44 lines

Diff 123851

View Options

sys/kern/subr_pctrie.c