opensolaris macros: drop INLINE_FLS checks
ClosedPublic
Actions

Authored by dougm on Jun 21 2023, 7:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 8:56 PM

	Unknown Object (File)
	Fri, Oct 10, 8:55 PM

	Unknown Object (File)
	Fri, Oct 10, 8:55 PM

	Unknown Object (File)
	Fri, Oct 10, 3:23 PM

	Unknown Object (File)
	Sep 14 2025, 11:58 AM

	Unknown Object (File)
	Sep 5 2025, 2:18 AM

	Unknown Object (File)
	Aug 28 2025, 1:41 AM

	Unknown Object (File)
	Aug 28 2025, 12:12 AM

View All 80 Files

Subscribers

imp

Details

Reviewers

mhorne
avg

Commits

rGe08776813087: inline_fls: remove redundant INLINE_FLS test

Summary

After D40698 is committed, HAS_INLINE_FLS and similar macros will be defined always. This change just removes the tests for these always-true conditions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 21 2023, 7:04 PM

dougm created this revision.

I am not sure where/if this file is used anymore. It originated as part of the Solaris/illumos ZFS implementation, which has been superseded by OpenZFS.

I tried quickly adding an #error directive to the header, but compiling a GENERIC amd64 kernel still succeeded.

In any case, making this change should be fine.

This revision is now accepted and ready to land.Jun 22 2023, 7:52 PM

Closed by commit rGe08776813087: inline_fls: remove redundant INLINE_FLS test (authored by dougm). · Explain WhyJul 6 2023, 6:32 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGe08776813087: inline_fls: remove redundant INLINE_FLS test.

Herald added a subscriber: imp. · View Herald TranscriptJul 6 2023, 6:32 PM