Page MenuHomeFreeBSD

pseudofs: Fix a potential out-of-bounds access in pfs_lookup()
ClosedPublic

Authored by markj on Jun 21 2023, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 19, 1:20 AM
Unknown Object (File)
Tue, May 19, 1:20 AM
Unknown Object (File)
Tue, May 19, 1:20 AM
Unknown Object (File)
Tue, May 19, 1:20 AM
Unknown Object (File)
Tue, May 19, 1:17 AM
Unknown Object (File)
Sun, May 3, 1:12 AM
Unknown Object (File)
Wed, Apr 29, 5:57 AM
Unknown Object (File)
Wed, Apr 29, 12:49 AM
Subscribers

Details

Summary

pseudofs nodes store their name in a flexible array member, so the node
allocation is sized using the length of the name, including a nul
terminator. pfs_lookup() scans a directory of nodes, comparing names to
find a match. The comparison was incorrect and assumed that all node
names were at least as long as the name being looked up, which of course
isn't true.

I believe the bug is mostly harmless since it cannot result in false
positive or negative matches from the lookup, but it triggers a KASAN
check.

Reported by: pho

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable