Page MenuHomeFreeBSD

riscv: improve KTR_TRAP trace entries
ClosedPublic

Authored by mhorne on Jun 17 2023, 4:59 PM.
Tags
None
Referenced Files
F154562036: D40584.id123427.diff
Tue, Apr 28, 10:20 PM
F154558882: D40584.id123427.diff
Tue, Apr 28, 10:12 PM
Unknown Object (File)
Mon, Apr 27, 3:54 PM
Unknown Object (File)
Mon, Apr 27, 6:18 AM
Unknown Object (File)
Wed, Apr 22, 2:26 AM
Unknown Object (File)
Wed, Apr 22, 2:18 AM
Unknown Object (File)
Tue, Apr 21, 3:52 PM
Unknown Object (File)
Wed, Apr 8, 4:48 AM
Subscribers

Details

Summary

For more informative records of exceptions, include key details such as
the exception code and stval contents. Add a new KTR_TRAP trace record
for interrupts.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/riscv/riscv/intr_machdep.c
167

KTR entries always contain a pointer to curthread (used to implement ktrdump -H), so including it here is redundant.

I wonder if the pointer to frame is ever useful?

sys/riscv/riscv/intr_machdep.c
167

Good point on curthread. For frame, probably not. It has a short lifetime and it's not like we can do much with it in ddb.

Drop curthread and trapframe arguments.

This revision is now accepted and ready to land.Jun 19 2023, 3:58 PM
This revision was automatically updated to reflect the committed changes.