Page MenuHomeFreeBSD

graphics/waffle: Update to 1.5.2

Authored by dumbbell on Oct 31 2015, 4:43 PM.
Referenced Files
Unknown Object (File)
Thu, May 11, 8:30 AM
Unknown Object (File)
May 9 2023, 1:38 AM
Unknown Object (File)
Feb 12 2023, 2:15 PM
Unknown Object (File)
Jan 18 2023, 12:05 AM
Unknown Object (File)
Jan 8 2023, 7:22 AM
Unknown Object (File)
Dec 12 2022, 12:37 PM
Unknown Object (File)
Dec 5 2022, 3:19 AM
Unknown Object (File)
Apr 24 2017, 3:26 PM



Beside the update, explicitely enable the x11_egl platform.

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

dumbbell retitled this revision from to graphics/waffle: Update to 1.5.2.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: kwm, zeising.

Should be fine overall, but has a number of minor style bugs (reported as inline comments).

19 ↗(On Diff #9852)

Options-related knobs are typically expected to be found near the very end of other knobs (right before targets section starts).

22 ↗(On Diff #9852)

Why these USE_* knobs are separated from the USES and USE_LDCONFIG above?

24 ↗(On Diff #9852)

Is LIBS (vs. LDFLAGS) really correct here? If not, you might consider using USES=localbase instead.

27 ↗(On Diff #9852)

These two successive += statements are usually done as one. In this case it looks like it would not even cause the linewrapping.

32 ↗(On Diff #9852)

I think this target is superfluous (i.e., stuff in DOCSDIR won't be packaged in docless package (ir)regardless of their presence in staging area).

Sort USE* variables and their values

kwm edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 5:08 PM
This revision was automatically updated to reflect the committed changes.