Differential D40475

arm/mpic: remove empty pic_init_secondary() hook
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Jun 9 2023, 5:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 5, 3:50 PM

	Unknown Object (File)
	Wed, Mar 4, 1:49 AM

	Unknown Object (File)
	Sun, Mar 1, 7:21 AM

	Unknown Object (File)
	Sun, Mar 1, 1:25 AM

	Unknown Object (File)
	Thu, Feb 26, 5:11 AM

	Unknown Object (File)
	Wed, Feb 25, 11:16 AM

	Unknown Object (File)
	Feb 8 2026, 9:39 AM

	Unknown Object (File)
	Feb 8 2026, 12:19 AM

Subscribers

Details

Reviewers

mmel
markj
andrew

Commits

rG6f242c69b604: arm/mpic: remove empty pic_init_secondary() hook
rGa8b2189c90c5: arm/mpic: remove empty pic_init_secondary() hook

Summary

The default hook does nothing, so having an empty handler is pointless.
Simple cleanup.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ehem_freebsd_m5p.com created this revision.Jun 9 2023, 5:45 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptJun 9 2023, 5:45 AM

ehem_freebsd_m5p.com requested review of this revision.Jun 9 2023, 5:45 AM

Harbormaster completed remote builds in B51975: Diff 122995.Jun 9 2023, 5:45 AM

There's a default implementation which does nothing, ok.

This revision is now accepted and ready to land.Jun 12 2023, 3:44 PM

ehem_freebsd_m5p.com mentioned this in D40474: intrng: call pic_init_secondary on all registered PICs.Jan 23 2024, 2:12 AM

Closed by commit rGa8b2189c90c5: arm/mpic: remove empty pic_init_secondary() hook (authored by ehem_freebsd_m5p.com, committed by jrtc27). · Explain WhyJan 23 2024, 2:55 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rGa8b2189c90c5: arm/mpic: remove empty pic_init_secondary() hook.

Herald added a reviewer: andrew. · View Herald TranscriptJan 23 2024, 2:55 AM

jrtc27 added a commit: rG6f242c69b604: arm/mpic: remove empty pic_init_secondary() hook.Sep 7 2024, 1:48 AM

Revision Contents
Changeset List

Path

Size

sys/

arm/

mv/

7 lines

Diff 133183

sys/arm/mv/mpic.c

Loading...