Page MenuHomeFreeBSD

Add helper to catch single step debug event and distinguish it from bkpt
ClosedPublic

Authored by zbb on Oct 30 2015, 4:15 PM.

Details

Summary

Some architectures (including ARMv6/v7) do not have separate single step
events and cannot see difference between breakpoint and single step.
Add db_pc_is_singlestep() to avoid skipping instruction we stepped on
to trigger debug event.
This commit does not change the existing functionality but adds possibility
to implement custom db_pc_is_singlestep().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zbb retitled this revision from to Add helper to catch single step debug event and distinguish it from bkpt.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: pfg, imp, ian.
zbb set the repository for this revision to rS FreeBSD src repository - subversion.

Any comments to this one :-) ?

pfg added a subscriber: zbb.

My FreeBSD box is unavailable at this time, which makes it difficult
to comment on phabricator :(.

The patch looks good to me though.

Pedro.

Il giorno 05/nov/2015, alle ore 09:50, zbb (Zbigniew Bodek) <phabric-noreply@FreeBSD.org> ha scritto:

zbb added a comment.

Ping?

REPOSITORY
rS FreeBSD src repository

REVISION DETAIL
https://reviews.freebsd.org/D4036

EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, pfg, imp, ian, andrew, wma_semihalf.com

imp edited edge metadata.
This revision is now accepted and ready to land.Nov 5 2015, 3:12 PM
This revision was automatically updated to reflect the committed changes.