Page MenuHomeFreeBSD
Differential D4036

Add helper to catch single step debug event and distinguish it from bkpt
ClosedPublic
Actions

Authored by zbb on Oct 30 2015, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 2:10 AM
Unknown Object (File)
Oct 16 2024, 2:07 AM
Unknown Object (File)
Oct 16 2024, 2:06 AM
Unknown Object (File)
Oct 16 2024, 1:26 AM
Unknown Object (File)
Oct 16 2024, 1:26 AM
Unknown Object (File)
Oct 5 2024, 12:56 PM
Unknown Object (File)
Oct 5 2024, 11:52 AM
Unknown Object (File)
Oct 2 2024, 7:45 PM
View All 92 Files
Subscribers
zbb

Details

Reviewers
pfg
andrew
imp
wma_semihalf.com
• ian
Commits
rS291407: Add helper to catch single step debug event and distinguish it from bkpt
Summary

Some architectures (including ARMv6/v7) do not have separate single step
events and cannot see difference between breakpoint and single step.
Add db_pc_is_singlestep() to avoid skipping instruction we stepped on
to trigger debug event.
This commit does not change the existing functionality but adds possibility
to implement custom db_pc_is_singlestep().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zbb updated this revision to Diff 9824.Oct 30 2015, 4:15 PM
zbb retitled this revision from to Add helper to catch single step debug event and distinguish it from bkpt.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: pfg, imp, • ian.
zbb set the repository for this revision to rS FreeBSD src repository - subversion.
zbb added a child revision: D4037: Introduce support for HW watchpoints and single stepping for ARMv6/v7.Oct 30 2015, 4:17 PM
zbb added a reviewer: andrew.Nov 2 2015, 7:30 PM

Any comments to this one :-) ?

zbb added a reviewer: wma_semihalf.com.Nov 3 2015, 6:35 PM
zbb added a comment.Nov 5 2015, 2:50 PM

Ping?

pfg edited edge metadata.Nov 5 2015, 3:05 PM
pfg added a subscriber: zbb.

My FreeBSD box is unavailable at this time, which makes it difficult
to comment on phabricator :(.

The patch looks good to me though.

Pedro.

Il giorno 05/nov/2015, alle ore 09:50, zbb (Zbigniew Bodek) <phabric-noreply@FreeBSD.org> ha scritto:

zbb added a comment.

Ping?

REPOSITORY
rS FreeBSD src repository

REVISION DETAIL
https://reviews.freebsd.org/D4036

EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, pfg, imp, ian, andrew, wma_semihalf.com

imp accepted this revision.Nov 5 2015, 3:12 PM
imp edited edge metadata.
This revision is now accepted and ready to land.Nov 5 2015, 3:12 PM
Closed by commit rS291407: Add helper to catch single step debug event and distinguish it from bkpt (authored by zbb). · Explain WhyNov 30 2015, 7:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
ddb/
24 lines

Diff 10575

View Options

head/sys/ddb/db_run.c

Loading...