Differential D40341

unbound: avoid calling deprecated OpenSSL function
ClosedPublic
Actions

Authored by emaste on May 30 2023, 9:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 21, 9:58 AM

	Unknown Object (File)
	Fri, Apr 17, 11:27 AM

	Unknown Object (File)
	Thu, Apr 16, 2:14 PM

	Unknown Object (File)
	Apr 15 2026, 1:00 PM

	Unknown Object (File)
	Apr 11 2026, 4:31 PM

	Unknown Object (File)
	Apr 6 2026, 4:34 AM

	Unknown Object (File)
	Mar 18 2026, 2:34 AM

	Unknown Object (File)
	Mar 18 2026, 2:34 AM

Subscribers

Details

Reviewers

des
khorben
ngie

Commits

rGdc103686348d: unbound: avoid calling deprecated OpenSSL function

Summary

SSL_CTX_set_ecdh_auto is deprecated and has no effect (for reference see https://github.com/openssl/openssl/commit/2ecb9f2d18614fb7b7b42830a358b7163ed43221).

As unbound's config.h is manually maintained just turn off HAVE_DECL_SSL_CTX_SET_ECDH_AUTO so that it won't be called.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.May 30 2023, 9:42 PM

emaste created this revision.

emaste added a reviewer: ngie.

Sounds good to me! From https://www.openssl.org/docs/man3.1/man3/SSL_CTX_set_ecdh_auto.html :

SSL_CTX_set_ecdh_auto() and SSL_set_ecdh_auto() are deprecated and have no effect.

Oddly enough this function doesn't appear to be documented on 1.1..

This revision is now accepted and ready to land.May 30 2023, 11:10 PM

Closed by commit rGdc103686348d: unbound: avoid calling deprecated OpenSSL function (authored by emaste). · Explain WhyMay 30 2023, 11:56 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdc103686348d: unbound: avoid calling deprecated OpenSSL function.

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2023, 11:56 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

unbound/

2 lines

Diff 122638

usr.sbin/unbound/config.h

Loading...