Page MenuHomeFreeBSD
Differential D40250

LinuxKPI: add page pool skeleton
Needs ReviewPublic
Actions

Authored by bz on Tue, May 23, 11:23 PM.
Tags
None
Referenced Files
F62419785: D40250.id122345.diff
Tue, Jun 6, 9:01 PM
Unknown Object (File)
Sat, May 27, 9:00 PM
Unknown Object (File)
Sat, May 27, 8:45 PM
Unknown Object (File)
Sat, May 27, 4:52 PM
Unknown Object (File)
Fri, May 26, 2:33 AM
Unknown Object (File)
Thu, May 25, 5:24 AM
Subscribers
emaste
imp
markj

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

Add the page pool skeleton based on a wireless driver. We have to
sort out some struct page problems first before we can start
implementing this but that should happen independent of all other
changes.

MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51663
Build 48554: arc lint + arc unit

Event Timeline

bz created this revision.Tue, May 23, 11:23 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptTue, May 23, 11:23 PM
bz requested review of this revision.Tue, May 23, 11:23 PM
Harbormaster completed remote builds in B51659: Diff 122345.Tue, May 23, 11:23 PM
emaste added inline comments.Tue, May 23, 11:58 PM
sys/compat/linuxkpi/common/include/net/page_pool.h
73

looks like this should take another arg?

89

could this be const? (even if not matching linux)

bz updated this revision to Diff 122351.Wed, May 24, 8:31 AM
bz marked an inline comment as done.

Make function argument const as suggested by @emaste

Harbormaster completed remote builds in B51663: Diff 122351.Wed, May 24, 8:31 AM
bz added inline comments.Wed, May 24, 8:31 AM
sys/compat/linuxkpi/common/include/net/page_pool.h
73

Based on what? Have they changed things already again? Based on roughly v6.4-rc1 driver I see:

page = page_pool_dev_alloc_frag(q->page_pool, offset, size);
89

Probably. Given the input I get from the driver wasn't const I hadn't put thought into it yet. Not sure what Linux does. I'll change it.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
net/
119 lines

Diff 122351

View Options

sys/compat/linuxkpi/common/include/net/page_pool.h

Loading...