Page MenuHomeFreeBSD

New committer (src): Christos Margiolis (christos)
ClosedPublic

Authored by christos on May 22 2023, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:33 PM
Unknown Object (File)
Oct 25 2024, 7:38 AM
Unknown Object (File)
Oct 10 2024, 5:39 AM
Unknown Object (File)
Oct 8 2024, 11:57 PM
Unknown Object (File)
Sep 22 2024, 4:38 AM
Unknown Object (File)
Sep 21 2024, 6:39 PM
Unknown Object (File)
Sep 21 2024, 7:44 AM
Unknown Object (File)
Sep 2 2024, 7:05 AM
Subscribers
None

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51603
Build 48494: arc lint + arc unit

Event Timeline

christos created this revision.

Approved with that nit addressed.

documentation/content/en/articles/pgpkeys/_index.adoc
1462

I think this is supposed to be sorted by last name, though that's not obvious. That'd put you between dwmalone and marino.

christos marked an inline comment as done.

Address Mark's comment.

Approved

website/data/en/news/news.toml
3

@emaste can you get this one through since I don't have a doc/ commit bit?

Approved.

(You can commit to doc/ as well with approval.)

This revision is now accepted and ready to land.May 23 2023, 3:28 PM

@emaste can you get this one through since I don't have a doc/ commit bit?

You should be able to commit to doc regardless. In general you're supposed to get some kind of approval in order to commit to a tree where you don't have formal commit access: https://docs.freebsd.org/en/articles/committers-guide/#_policy_for_committer_activity_in_other_trees

In this case, I *think* you can just go ahead even though I don't have a doc bit either. If @emaste can approve, then all the better.

In this case, I *think* you can just go ahead even though I don't have a doc bit either.

Yes, I think we had a special case for updates to these files for adding a committer