Page MenuHomeFreeBSD

ifconfig(8): Fix prototype for warn_nomask()
AbandonedPublic

Authored by otis on May 22 2023, 2:32 PM.
Tags
None
Referenced Files
F80128764: D40207.diff
Thu, Mar 28, 7:28 AM
Unknown Object (File)
Feb 18 2024, 8:28 AM
Unknown Object (File)
Dec 31 2023, 12:21 AM
Unknown Object (File)
Dec 4 2023, 5:46 PM
Unknown Object (File)
Nov 13 2023, 6:20 PM
Unknown Object (File)
Oct 5 2023, 3:30 AM
Unknown Object (File)
Sep 28 2023, 3:11 AM
Unknown Object (File)
Aug 7 2023, 1:18 PM
Subscribers

Details

Reviewers
melifaro
kp
Summary

ifflags is of type int

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51599
Build 48490: arc lint + arc unit

Event Timeline

otis requested review of this revision.May 22 2023, 2:32 PM
kp added a subscriber: kp.

LGTM, go ahead and commit that.

This revision is now accepted and ready to land.May 22 2023, 2:38 PM

Whoops. How did I miss that?

It's not OK, because the build was fixed, although:

root@b14:~ # ifconfig vtnet0 inet 100.64.0.14/24
Bus error (core dumped)

I'll investigate whether this is only my problem (although this box is pretty vanilla -CURRENT).

In D40207#915288, @otis wrote:

It's not OK, because the build was fixed, although:

root@b14:~ # ifconfig vtnet0 inet 100.64.0.14/24
Bus error (core dumped)

I'll investigate whether this is only my problem (although this box is pretty vanilla -CURRENT).

Hm. is this amd64?

In D40207#915288, @otis wrote:

It's not OK, because the build was fixed, although:

root@b14:~ # ifconfig vtnet0 inet 100.64.0.14/24
Bus error (core dumped)

I'll investigate whether this is only my problem (although this box is pretty vanilla -CURRENT).

Hm. is this amd64?

Yes, amd64, clean build from today's afternoon (CEST).

In D40207#915290, @otis wrote:
In D40207#915288, @otis wrote:

It's not OK, because the build was fixed, although:

root@b14:~ # ifconfig vtnet0 inet 100.64.0.14/24
Bus error (core dumped)

I'll investigate whether this is only my problem (although this box is pretty vanilla -CURRENT).

Hm. is this amd64?

Yes, amd64, clean build from today's afternoon (CEST).

Any chance you're in IRC/slack/any other IM and can debug with me?
If not, I'll disable Netlink switch and we'll figure it out offline.
For me, ifconfig works and passes all tests.

After return from:

* thread #1, name = 'ifconfig', stop reason = step over
    frame #0: 0x00002eff65fa48d5 ifconfig`in_exec_nl(h=0x00002f0786320090, action=<unavailable>, data=<unavailable>) at af_inet.c:359:1                   356                   warnx("%s(): %s", __func__, e.error_str);                                                                                        357
   358           return (e.error);                                                                                                                     -> 359   }

it continued to:

Process 1284 stopped
* thread #1, name = 'ifconfig', stop reason = step in
    frame #0: 0x00002eff65fa1e30 ifconfig`usage at ifconfig.c:181:13                                                                                      178           struct option *p;
   179
   180           /* XXX not right but close enough for now */
-> 181           options[0] = '\0';
   182           for (p = opts; p != NULL; p = p->next) {
   183                   strlcat(options, p->opt_usage, sizeof(options));
   184                   strlcat(options, " ", sizeof(options));

And then, after some iterations:

Process 1284 stopped
* thread #1, name = 'ifconfig', stop reason = step over                                                                                                    frame #0: 0x00002eff65fa1e8a ifconfig`usage at ifconfig.c:187:10
   184                   strlcat(options, " ", sizeof(options));
   185           }
   186
-> 187           fprintf(stderr,
   188           "usage: ifconfig [-f type:format] %sinterface address_family\n"
   189           "                [address [dest_address]] [parameters]\n"
   190           "       ifconfig interface create\n"
(lldb)
Process 1284 stopped
* thread #1, name = 'ifconfig', stop reason = signal SIGBUS: hardware error
    frame #0: 0x00002f078c28e1c1 libc.so.7`__vfprintf(fp=0x00002f078631f920, locale=0x00002f078c34f278, fmt0="usage: ifconfig [-f type:format] %sinterf
ace address_family\n                [address [dest_address]] [parameters]\n       ifconfig interface create\n       ifconfig -a %s[-d] [-m] [-u] [-v] [
address_family]\n       ifconfig -l [-d] [-u] [address_family]\n       ifconfig %s[-d] [-m] [-u] [-v]\n", ap=0x00002f078631fbc8) at vfprintf.c:475:2
   472           fmt = (char *)fmt0;
   473           argtable = NULL;
   474           nextarg = 1;
-> 475           va_copy(orgap, ap);
   476           io_init(&io, fp);
   477           ret = 0;
   478   #ifndef NO_FLOATING_POINT
(lldb) bt
* thread #1, name = 'ifconfig', stop reason = signal SIGBUS: hardware error

If you need an access to that VM, i can provide it.

This needed to be addressed in more appropriate manner. (And actually was, in different diffs).