magick.mk: Improve readability
ClosedPublic
Actions

Authored by zirias on May 6 2023, 10:42 AM.

Tags

None

Referenced Files

	F82851133: D39986.diff
	Fri, May 3, 5:04 AM

	Unknown Object (File)
	Feb 22 2024, 10:11 PM

	Unknown Object (File)
	Jan 13 2024, 8:37 AM

	Unknown Object (File)
	Dec 23 2023, 1:22 AM

	Unknown Object (File)
	Dec 7 2023, 10:11 PM

	Unknown Object (File)
	Nov 9 2023, 2:35 AM

	Unknown Object (File)
	Oct 17 2023, 4:55 AM

	Unknown Object (File)
	Oct 12 2023, 7:30 AM

View All 15 Files

Subscribers

cperciva

mat

Details

Reviewers

tcberner

Group Reviewers

portmgr

Commits

R11:326005b3bb9f: Mk/Uses/magick.mk: Improve readability

Summary

Improve readability by replacing the AT&T-style expansions with some
explicit logic. This also avoids incompatibility with very old make
versions where % in these expansions also matches empty strings.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 51354
Build 48245: arc lint + arc unit

Event Timeline

zirias created this revision.May 6 2023, 10:42 AM

Herald added a reviewer: portmgr. · View Herald TranscriptMay 6 2023, 10:42 AM

Herald added a subscriber: mat. · View Herald Transcript

zirias requested review of this revision.May 6 2023, 10:42 AM

Harbormaster completed remote builds in B51353: Diff 121603.May 6 2023, 10:42 AM

Drop stray empty line ...

Harbormaster completed remote builds in B51354: Diff 121604.May 6 2023, 10:44 AM

lgtm

This revision is now accepted and ready to land.May 9 2023, 6:14 AM

Closed by commit R11:326005b3bb9f: Mk/Uses/magick.mk: Improve readability (authored by zirias). · Explain WhyMay 9 2023, 6:22 AM

This revision was automatically updated to reflect the committed changes.

zirias added a commit: R11:326005b3bb9f: Mk/Uses/magick.mk: Improve readability.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

magick.mk

15 lines

Diff 121604

View Options

Mk/Uses/magick.mk: Improve readabilityClosedPublicActions