Page MenuHomeFreeBSD
Differential D3995

Disable context descriptor reuse if num_queues > 1
ClosedPublic
Actions

Authored by sbruno on Oct 23 2015, 9:00 PM.
Tags
None
Referenced Files
F103256601: D3995.diff
Fri, Nov 22, 5:16 PM
F103247011: D3995.id12007.diff
Fri, Nov 22, 2:43 PM
Unknown Object (File)
Sun, Nov 17, 3:57 PM
Unknown Object (File)
Fri, Nov 15, 12:37 AM
Unknown Object (File)
Thu, Nov 14, 3:47 AM
Unknown Object (File)
Sat, Oct 26, 6:24 PM
Unknown Object (File)
Sat, Oct 26, 6:24 PM
Unknown Object (File)
Sat, Oct 26, 6:23 PM
View All 83 Files
Subscribers
hiren
imp

Details

Reviewers
erj
Group Reviewers
Intel Networking
Commits
rS293332: Disable the reuse of checksum offload context descriptors in the case
Summary

Disable context descriptor reuse if num_queues > 1

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sbruno updated this revision to Diff 9671.Oct 23 2015, 9:00 PM
sbruno retitled this revision from to Disable context descriptor reuse if num_queues > 1.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added a reviewer: erj.
sbruno added a subscriber: hiren.
Herald added a reviewer: Intel Networking. · View Herald TranscriptOct 23 2015, 9:00 PM
Herald added a subscriber: imp. · View Herald Transcript
hiren added a comment.Oct 23 2015, 9:25 PM

Looks okay to me. I am sure commit-log will have all the details but it'd be useful to have which problem/behavior prompted this fix.
Also I am seeing weird whitespaces. Not sure if its phabric or not. (lines 3744 and 3791)

erj edited edge metadata.Oct 23 2015, 9:26 PM

Did not re-using context descriptors work out for you, and you don't see the wrong queue value in the receive descriptor?

sbruno added a comment.Oct 25 2015, 8:18 PM
In D3995#83298, @erj wrote:

Did not re-using context descriptors work out for you, and you don't see the wrong queue value in the receive descriptor?

This only affects the TX side here. Context descriptor reuse cannot be enabled on the 82574L (and probably all e1000 class) due to the hardware only being able to remember the last context.

Closed by commit rS293332: Disable the reuse of checksum offload context descriptors in the case (authored by sbruno). · Explain WhyJan 7 2016, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
e1000/
108 lines

Diff 12007

View Options

head/sys/dev/e1000/if_em.c

Loading...