pkgbase: hide duplicate METALOG directory warnings under verbose

[emaste]

Summary

Creating directories multiple times is an inherent side effect of the
way installation is done.  Hide warnings from duplicate directory
entries (with identical metadata) under verbose mode.

PR:             244596
Sponsored By:   The FreeBSD Foundation

[emaste]

Rework so that non-dir duplicates can be errors

It looks like there are three right now - once those are fixed they will be changed to errors

warning: ./boot/loader.help.bios file repeated with same meta: line 26843,26846,26851
warning: ./boot/loader.help.efi file repeated with same meta: line 26867,26870,26874
warning: ./boot/loader.help.userboot file repeated with same meta: line 26821,26825

[emaste]

Prefix error with error: and add a comment about why we're making it just a warning for now

[mhorne]

In D39898#908254, @emaste wrote:

Rework so that non-dir duplicates can be errors

It looks like there are three right now - once those are fixed they will be changed to errors

warning: ./boot/loader.help.bios file repeated with same meta: line 26843,26846,26851
warning: ./boot/loader.help.efi file repeated with same meta: line 26867,26870,26874
warning: ./boot/loader.help.userboot file repeated with same meta: line 26821,26825

I believe this duplication comes from the different loader variants, e.g. loader_lua.efi, loader_forth.efi, and loader_simp.efi all use the loader.help.efi filename. I am not sure what we should do to handle this better.

[emaste]

PR271178 for the multiply-installed files

[imp]

In D39898#908279, @mhorne wrote:

In D39898#908254, @emaste wrote:

Rework so that non-dir duplicates can be errors

It looks like there are three right now - once those are fixed they will be changed to errors

warning: ./boot/loader.help.bios file repeated with same meta: line 26843,26846,26851
warning: ./boot/loader.help.efi file repeated with same meta: line 26867,26870,26874
warning: ./boot/loader.help.userboot file repeated with same meta: line 26821,26825

I believe this duplication comes from the different loader variants, e.g. loader_lua.efi, loader_forth.efi, and loader_simp.efi all use the loader.help.efi filename. I am not sure what we should do to handle this better.

we've had similaar issues in the past for man pages. when the tree was update to have more unique help files, this problem crept in with that.

[kevans]

One typo, LGTM otherwise

tools/pkgbase/metalog_reader.lua

400