stand: More protection against malformed smbios tables
ClosedPublic
Actions

Authored by imp on Apr 25 2023, 4:25 AM.

Tags

None

Referenced Files

	F84903706: D39794.diff
	Wed, May 29, 10:43 PM

	Unknown Object (File)
	Sun, May 19, 11:03 PM

	Unknown Object (File)
	Sun, May 19, 3:47 PM

	Unknown Object (File)
	Thu, May 16, 1:15 AM

	Unknown Object (File)
	Thu, May 16, 12:56 AM

	Unknown Object (File)
	Mar 14 2024, 10:40 PM

	Unknown Object (File)
	Mar 14 2024, 10:40 PM

	Unknown Object (File)
	Mar 13 2024, 1:51 AM

View All 17 Files

Subscribers

dab

Details

Reviewers

manu
kevans

Commits

rGa5b4ec528192: stand: More protection against malformed smbios tables

Summary

Add some more sanity checks to make sure we don't march off the end of
the table. Typically, smbios structures are well formed, or Windows
wouldn't boot. Sometimes they aren't, and this at least fails safe.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 25 2023, 4:25 AM

Herald added a reviewer: manu. · View Herald TranscriptApr 25 2023, 4:25 AM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Apr 25 2023, 4:25 AM

Harbormaster completed remote builds in B51169: Diff 120979.Apr 25 2023, 4:25 AM

imp added a parent revision: D39793: stand: Avoid unaligned access in smbios code.Apr 25 2023, 4:25 AM

imp added a reviewer: kevans.Apr 25 2023, 4:26 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2023, 9:29 PM

Closed by commit rGa5b4ec528192: stand: More protection against malformed smbios tables (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa5b4ec528192: stand: More protection against malformed smbios tables.

Revision Contents
Changeset List

Path

Size

stand/

libsa/

smbios.c

12 lines

Diff 121358

View Options

stand: More protection against malformed smbios tablesClosedPublicActions