Page MenuHomeFreeBSD
Differential D39430

makefs(8): do not print comma after the last super-block
ClosedPublic
Actions

Authored by christos on Apr 5 2023, 3:42 PM.
Tags
None
Referenced Files
F87431430: D39430.diff
Tue, Jul 2, 11:14 PM
Unknown Object (File)
Thu, Jun 27, 12:42 AM
Unknown Object (File)
Wed, Jun 26, 7:56 PM
Unknown Object (File)
Mon, Jun 24, 10:28 PM
Unknown Object (File)
Mon, Jun 24, 5:20 AM
Unknown Object (File)
Sat, Jun 22, 3:20 PM
Unknown Object (File)
Fri, Jun 21, 8:11 PM
Unknown Object (File)
Thu, Jun 20, 8:30 PM
View All 27 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG18eb15bd8a11: makefs(8): do not print comma after the last super-block
rGf21faa67ab6b: makefs(8): do not print comma after the last super-block

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Apr 5 2023, 3:42 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 5 2023, 3:42 PM
christos requested review of this revision.Apr 5 2023, 3:42 PM
markj accepted this revision.Apr 5 2023, 4:30 PM
markj added inline comments.
usr.sbin/makefs/ffs/mkfs.c
534

Please fix the style while here, indentation of continuing lines should be by four spaces.

This revision is now accepted and ready to land.Apr 5 2023, 4:30 PM
christos updated this revision to Diff 119912.Apr 5 2023, 5:36 PM
christos marked an inline comment as done.
christos retitled this revision from makefs(8): do not print comma after the last super-block to makefs(8): do not print comma after the last super-block, fix continuing line indentation.
This revision now requires review to proceed.Apr 5 2023, 5:36 PM
markj added a reviewer: emaste.Apr 5 2023, 8:05 PM
emaste accepted this revision.Apr 5 2023, 8:10 PM

Looks good.
I would not include the unrelated whitespace fixes in the same commit though.

This revision is now accepted and ready to land.Apr 5 2023, 8:10 PM
christos added a comment.Apr 5 2023, 9:16 PM
In D39430#897729, @emaste wrote:

Looks good.
I would not include the unrelated whitespace fixes in the same commit though.

Alright, I'll split the commits.

christos updated this revision to Diff 119927.Apr 5 2023, 10:00 PM
christos retitled this revision from makefs(8): do not print comma after the last super-block, fix continuing line indentation to makefs(8): do not print comma after the last super-block.

Depend on D39443.

This revision now requires review to proceed.Apr 5 2023, 10:00 PM
christos added a parent revision: D39443: makefs(8): fix continuing lines' indentation.Apr 5 2023, 10:01 PM
markj added a comment.Apr 5 2023, 10:14 PM
In D39430#897729, @emaste wrote:

Looks good.
I would not include the unrelated whitespace fixes in the same commit though.

They're not unrelated, the affected lines have to be touched anyway. Otherwise I wouldn't have brought it up.

emaste added a comment.Apr 5 2023, 10:22 PM

I mean the changes on line 252 etc.

markj added a comment.Apr 5 2023, 10:23 PM
In D39430#897815, @emaste wrote:

I mean the changes on line 252 etc.

Oh, sorry. I missed the intermediate version. I'll just commit the two-line change then.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2023, 10:40 PM
Closed by commit rGf21faa67ab6b: makefs(8): do not print comma after the last super-block (authored by christos, committed by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGf21faa67ab6b: makefs(8): do not print comma after the last super-block.
markj added a commit: rG18eb15bd8a11: makefs(8): do not print comma after the last super-block.Apr 12 2023, 2:23 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
ffs/
5 lines

Diff 119928

View Options

usr.sbin/makefs/ffs/mkfs.c

Loading...