Page MenuHomeFreeBSD

arm64/disassem.c: Add support str/strb/strh instructions
ClosedPublic

Authored by koliagogsadze_gmail.com on Mar 29 2023, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 9, 12:52 AM
Unknown Object (File)
May 18 2026, 2:12 AM
Unknown Object (File)
May 18 2026, 2:11 AM
Unknown Object (File)
May 18 2026, 2:00 AM
Unknown Object (File)
Apr 29 2026, 12:26 AM
Unknown Object (File)
Apr 28 2026, 3:26 AM
Unknown Object (File)
Apr 23 2026, 3:33 AM
Unknown Object (File)
Apr 20 2026, 12:58 PM
Subscribers

Details

Summary

Added dissassembly support for all types str/strb/strh instruction enconding.

Test Plan

Tested all possible combinations, test branch where I manually
tested my changes:
https://github.com/freebsd/freebsd-src/compare/main...toor1245:freebsd-src:arm64-disasm-str-test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me, thanks for linking the documentation!

sys/arm64/arm64/disassem.c
199

The only thing I'm unsure about is the OP_SF32. It's exact purpose is not so clear to me but I trust it's correct based on ldrb/ldrh and your testing.

This revision is now accepted and ready to land.Apr 14 2023, 6:14 PM