Page MenuHomeFreeBSD

arm64/disassem.c: Add support str/strb/strh instructions
ClosedPublic

Authored by koliagogsadze_gmail.com on Mar 29 2023, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 10:17 AM
Unknown Object (File)
Tue, Dec 9, 1:42 PM
Unknown Object (File)
Tue, Dec 2, 12:57 PM
Unknown Object (File)
Fri, Nov 28, 4:44 PM
Unknown Object (File)
Sun, Nov 23, 4:18 PM
Unknown Object (File)
Sat, Nov 15, 12:20 AM
Unknown Object (File)
Oct 27 2025, 7:30 PM
Unknown Object (File)
Oct 25 2025, 12:50 AM
Subscribers

Details

Summary

Added dissassembly support for all types str/strb/strh instruction enconding.

Test Plan

Tested all possible combinations, test branch where I manually
tested my changes:
https://github.com/freebsd/freebsd-src/compare/main...toor1245:freebsd-src:arm64-disasm-str-test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me, thanks for linking the documentation!

sys/arm64/arm64/disassem.c
199

The only thing I'm unsure about is the OP_SF32. It's exact purpose is not so clear to me but I trust it's correct based on ldrb/ldrh and your testing.

This revision is now accepted and ready to land.Apr 14 2023, 6:14 PM