Page MenuHomeFreeBSD

arm64/disassem.c: Add support str/strb/strh instructions
ClosedPublic

Authored by koliagogsadze_gmail.com on Mar 29 2023, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 12:47 PM
Unknown Object (File)
May 2 2024, 5:07 AM
Unknown Object (File)
Jan 5 2024, 5:46 PM
Unknown Object (File)
Dec 25 2023, 5:13 PM
Unknown Object (File)
Dec 24 2023, 2:20 AM
Unknown Object (File)
Dec 12 2023, 11:54 AM
Unknown Object (File)
Dec 9 2023, 5:54 AM
Unknown Object (File)
Nov 23 2023, 5:21 PM
Subscribers

Details

Summary

Added dissassembly support for all types str/strb/strh instruction enconding.

Test Plan

Tested all possible combinations, test branch where I manually
tested my changes:
https://github.com/freebsd/freebsd-src/compare/main...toor1245:freebsd-src:arm64-disasm-str-test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me, thanks for linking the documentation!

sys/arm64/arm64/disassem.c
199

The only thing I'm unsure about is the OP_SF32. It's exact purpose is not so clear to me but I trust it's correct based on ldrb/ldrh and your testing.

This revision is now accepted and ready to land.Apr 14 2023, 6:14 PM