iicbus: Use device_delete_children() instead of explicit child removal
ClosedPublic
Actions

Authored by dumbbell on Oct 17 2015, 2:54 PM.

Details

Reviewers

kib
jhb
imp

Commits

rS294490: iicbus: Use device_delete_children() instead of explicit child removal
rS289657: iicbus: Use device_delete_children() instead of explicit child removal

Summary

If the bus is detached and deleted by a call to device_delete_child() or device_delete_children() on a device higher in the tree, I²C children were already detached and deleted. So the device_t pointer stored in sc points to freed memory: we must not try to delete it again.

The same change is applied to my i915 WIP branch to the i915 driver. This fixes a general protection fault users reported.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell updated this revision to Diff 9469.Oct 17 2015, 2:54 PM

dumbbell retitled this revision from to iicbus: Use device_delete_children() instead of explicit child removal If the bus is detached and deleted by a call to device_delete_child() or device_delete_children() on a device higher in the tree, I²C children were already detached and....

dumbbell updated this object.

dumbbell edited the test plan for this revision. (Show Details)

dumbbell added reviewers: jhb, kib.

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2015, 2:54 PM

dumbbell updated this object.Oct 17 2015, 2:56 PM

dumbbell retitled this revision from iicbus: Use device_delete_children() instead of explicit child removal If the bus is detached and deleted by a call to device_delete_child() or device_delete_children() on a device higher in the tree, I²C children were already detached and... to iicbus: Use device_delete_children() instead of explicit child removal.

emaste added a subscriber: emaste.Oct 19 2015, 4:23 PM

jhb accepted this revision.Oct 19 2015, 9:29 PM

jhb edited edge metadata.

This revision is now accepted and ready to land.Oct 19 2015, 9:29 PM