libdtrace: get rid of illumos ifdefs in dt_module_update(), fix dm_file and dm_modid
ClosedPublic
Actions

christos retitled this revision from libdtrace: get rid of illumos ifdefs in dt_module_update() to libdtrace: get rid of illumos ifdefs in dt_module_update(), fix dm_file and dm_modid.Mar 20 2023, 10:58 PM

christos added a child revision: D38825: libdtrace: implement inline function tracing for kinst.Mar 20 2023, 11:30 PM

Approved, but the log message should explain the motivation in some detail: this function is highly OS-specific, and the ifdefs make it hard to read and follow what's going on. The removal of ".filename" section handling in particular should be mentioned.

This revision is now accepted and ready to land.Mon, May 22, 8:05 PM

Closed by commit rG6265da14c913: libdtrace: get rid of illumos ifdefs in dt_module_update(), fix dm_file and… (authored by christos). · Explain WhyTue, May 23, 12:56 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG6265da14c913: libdtrace: get rid of illumos ifdefs in dt_module_update(), fix dm_file and….

christos removed a child revision: D38825: libdtrace: implement inline function tracing for kinst.Tue, May 23, 2:23 PM