Page MenuHomeFreeBSD

libdtrace: get rid of illumos ifdefs in dt_module_update(), fix dm_file and dm_modid
ClosedPublic

Authored by christos on Mar 20 2023, 10:38 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, May 20, 3:43 PM
Unknown Object (File)
Mon, May 15, 5:38 AM
Unknown Object (File)
Apr 26 2023, 3:31 PM
Unknown Object (File)
Mar 30 2023, 3:17 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos retitled this revision from libdtrace: fix module file name to libdtrace: get rid of illumos ifdefs in dt_module_update().
christos edited the summary of this revision. (Show Details)
christos retitled this revision from libdtrace: get rid of illumos ifdefs in dt_module_update() to libdtrace: get rid of illumos ifdefs in dt_module_update(), fix dm_file and dm_modid.Mar 20 2023, 10:58 PM

Approved, but the log message should explain the motivation in some detail: this function is highly OS-specific, and the ifdefs make it hard to read and follow what's going on. The removal of ".filename" section handling in particular should be mentioned.

This revision is now accepted and ready to land.Mon, May 22, 8:05 PM