Page MenuHomeFreeBSD

kinst(4): search for push rbp anywhere in the function
AbandonedPublic

Authored by christos on Mar 18 2023, 7:33 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Sep 30, 8:03 PM
Unknown Object (File)
Thu, Sep 26, 7:36 PM
Unknown Object (File)
Tue, Sep 24, 10:03 AM
Unknown Object (File)
Tue, Sep 24, 4:02 AM
Unknown Object (File)
Thu, Sep 19, 12:16 PM
Unknown Object (File)
Mon, Sep 16, 7:45 PM
Unknown Object (File)
Sep 3 2024, 7:09 AM
Unknown Object (File)
Aug 21 2024, 6:54 AM
Subscribers

Details

Reviewers
markj
Summary

This patch fixes kinst ignoring functions that push %rbp
after the first instruction.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Mention leaf function with rbp omitted.

sys/cddl/dev/kinst/amd64/kinst_isa.c
542

Let's put this in its own function, something like bool kinst_can_trace_func(uint8_t *instr, uint8_t *limit);. kinst_make_probe() has too many local vars otherwise, and we might want to add/change the checks over time, so a separate function is a bit neater.

christos marked an inline comment as done.

Put it in its own function.

Abandoning this one since we no longer search for push %rbp, instead we
exclude just the exception handlers (see D39229).