Page MenuHomeFreeBSD

kinst(4): search for push rbp anywhere in the function
AbandonedPublic

Authored by christos on Mar 18 2023, 7:33 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Jul 9, 7:04 PM
Unknown Object (File)
Fri, Jun 28, 6:59 PM
Unknown Object (File)
Sun, Jun 23, 12:39 PM
Unknown Object (File)
Mar 11 2024, 2:57 PM
Unknown Object (File)
Dec 21 2023, 4:04 AM
Unknown Object (File)
Dec 20 2023, 1:25 PM
Unknown Object (File)
Dec 20 2023, 4:17 AM
Unknown Object (File)
Dec 10 2023, 6:26 PM
Subscribers

Details

Reviewers
markj
Summary

This patch fixes kinst ignoring functions that push %rbp
after the first instruction.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Mention leaf function with rbp omitted.

sys/cddl/dev/kinst/amd64/kinst_isa.c
541

Let's put this in its own function, something like bool kinst_can_trace_func(uint8_t *instr, uint8_t *limit);. kinst_make_probe() has too many local vars otherwise, and we might want to add/change the checks over time, so a separate function is a bit neater.

christos marked an inline comment as done.

Put it in its own function.

Abandoning this one since we no longer search for push %rbp, instead we
exclude just the exception handlers (see D39229).