Page MenuHomeFreeBSD

kinst(4): search for push rbp anywhere in the function
AbandonedPublic

Authored by christos on Mar 18 2023, 7:33 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, May 18, 10:41 AM
Unknown Object (File)
Fri, May 16, 10:59 PM
Unknown Object (File)
Sun, May 11, 4:02 PM
Unknown Object (File)
Sun, May 4, 3:44 AM
Unknown Object (File)
Apr 24 2025, 4:43 AM
Unknown Object (File)
Apr 22 2025, 7:13 PM
Unknown Object (File)
Apr 21 2025, 8:17 AM
Unknown Object (File)
Apr 17 2025, 5:17 PM
Subscribers

Details

Reviewers
markj
Summary

This patch fixes kinst ignoring functions that push %rbp
after the first instruction.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Mention leaf function with rbp omitted.

sys/cddl/dev/kinst/amd64/kinst_isa.c
555

Let's put this in its own function, something like bool kinst_can_trace_func(uint8_t *instr, uint8_t *limit);. kinst_make_probe() has too many local vars otherwise, and we might want to add/change the checks over time, so a separate function is a bit neater.

christos marked an inline comment as done.

Put it in its own function.

Abandoning this one since we no longer search for push %rbp, instead we
exclude just the exception handlers (see D39229).