Page MenuHomeFreeBSD

kerneldump: Inline dump_savectx() into its callers
ClosedPublic

Authored by markj on Mar 18 2023, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 27, 9:20 AM
Unknown Object (File)
Sun, Jul 26, 3:43 PM
Unknown Object (File)
Sat, Jul 25, 3:31 AM
Unknown Object (File)
Mon, Jul 20, 3:39 PM
Unknown Object (File)
Mon, Jul 13, 2:49 PM
Unknown Object (File)
Sun, Jul 5, 5:48 AM
Unknown Object (File)
Sat, Jul 4, 4:32 AM
Unknown Object (File)
Fri, Jul 3, 1:54 AM
Subscribers

Details

Summary

The callers of dump_savectx() (i.e., doadump() and livedump_start())
subsequently call dumpsys()/minidumpsys(), which dump the calling
thread's stack when writing the dump. If dump_savectx() gets its own
stack frame, that frame might be clobbered when its caller later calls
dumpsys()/minidumpsys(), making it difficult for debuggers to unwind the
stack.

Fix this by making dump_savectx() a macro, so that savectx() is always
called directly by the function which subsequently calls
dumpsys()/minidumpsys().

This fixes stack unwinding for the panicking thread from arm64
minidumps. The same happened to work on amd64, but kgdb reports the
dump_savectx() calls as coming from dumpsys(), so in that case it
appears to work by accident.

Fixes: c9114f9f86f9 ("Add new vnode dumper to support live minidumps")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable