Page MenuHomeFreeBSD
Differential D3903

Change improper locking assertion in mge
ClosedPublic
Actions

Authored by bsz_semihalf.com on Oct 15 2015, 12:41 PM.
Tags
Referenced Files
F167378306: D3903.id9702.diff
Fri, Aug 21, 11:18 AM
F167377474: D3903.id9413.diff
Fri, Aug 21, 11:14 AM
F167377268: D3903.id9413.diff
Fri, Aug 21, 11:13 AM
F167376904: D3903.diff
Fri, Aug 21, 11:12 AM
Unknown Object (File)
Thu, Aug 13, 12:38 PM
Unknown Object (File)
Fri, Aug 7, 1:57 PM
Unknown Object (File)
Fri, Aug 7, 8:17 AM
Unknown Object (File)
Thu, Aug 6, 2:42 PM
View All Files
Subscribers
imp

Details

Reviewers
zbb
adrian
• ian
Commits
rS289948: Change improper locking assertion in mge
Summary

Assertion used here was not atomic (locks' state could change between consecutive 'if' conditions), what could lead to unwanted panic(). Moreover, it was wrong itself: it is *not* a problem if one of the locks is held during MGE_GLOBAL_LOCK.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bsz_semihalf.com updated this revision to Diff 9413.Oct 15 2015, 12:41 PM
bsz_semihalf.com retitled this revision from to Change improper locking assertion in mge.
bsz_semihalf.com updated this object.
bsz_semihalf.com edited the test plan for this revision. (Show Details)
bsz_semihalf.com added reviewers: adrian, • ian, zbb.
bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
bsz_semihalf.com added a project: network.
Herald added a subscriber: imp. · View Herald TranscriptOct 15 2015, 12:41 PM
Closed by commit rS289948: Change improper locking assertion in mge (authored by zbb). · Explain WhyOct 25 2015, 10:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
mge/
6 lines

Diff 9702

View Options

head/sys/dev/mge/if_mgevar.h

Loading...