Page MenuHomeFreeBSD

cap_*(2): Document ENOSYS behavior.
ClosedPublic

Authored by delphij on Mar 8 2023, 5:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 18 2024, 1:01 PM
Unknown Object (File)
Dec 20 2023, 7:18 AM
Unknown Object (File)
Dec 12 2023, 9:46 AM
Unknown Object (File)
Dec 1 2023, 8:54 AM
Unknown Object (File)
Oct 12 2023, 6:17 AM
Unknown Object (File)
Oct 8 2023, 2:46 PM
Unknown Object (File)
Aug 15 2023, 2:26 AM
Unknown Object (File)
Aug 15 2023, 12:48 AM

Details

Summary

All cap_* system calls would fail when capability mode support is
not present.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sounds reasonable, one little comment.

lib/libc/sys/cap_enter.2
116–117

"Currently running" seems redundant, and to me seems a bit awkward. How about "The running kernel..."

This revision is now accepted and ready to land.Mar 8 2023, 1:26 PM
pauamma_gundo.com added inline comments.
lib/libc/sys/cap_enter.2
116–117

Even if not going for that suggestion, this noun phrase needs "the".

lib/libc/sys/cap_fcntls_limit.2
114

Same as above.

lib/libc/sys/cap_ioctls_limit.2
141

And again.

146–148

Repeats text from above.

lib/libc/sys/cap_rights_limit.2
124

The

This revision now requires changes to proceed.Mar 8 2023, 10:33 PM

Thanks for the detailed review! Could you please take another look at the updated changeset?

lib/libc/sys/cap_ioctls_limit.2
146–148

This is a different system call so technically it should stay. I've combined the common errors into one and have a separate listing for cap_ioctls_limit instead.

delphij marked an inline comment as done.

Address reviewer comments.

Ignore the "request changes" from Doc Committers. I'm not allowed to approve as that group while under mentorship, but (unless I missed something) Phabricator didn't let me uncheck any checkboxes when I requested changes earlier. :-(

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2023, 2:11 AM
This revision was automatically updated to reflect the committed changes.