bcm_dma: don't dereference NULL softc
ClosedPublic
Actions

Authored by mhorne on Feb 24 2023, 2:06 PM.

Details

Reviewers

manu
kevans

Commits

rGaa399ad3e554: bcm_dma: don't dereference NULL softc
rG07ccf71451d7: bcm_dma: don't dereference NULL softc

Summary

This file defines a small API to be used by other drivers. If any of
these functions are called before the bcm_dma device has attached we
should handle the error gracefully. Fix a formatting quirk while here.

The issue related to device attach order is fixed in PR 268835.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Feb 24 2023, 2:06 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptFeb 24 2023, 2:06 PM

mhorne requested review of this revision.Feb 24 2023, 2:06 PM

Harbormaster completed remote builds in B49991: Diff 117875.Feb 24 2023, 2:06 PM

manu accepted this revision.Feb 24 2023, 2:43 PM

This revision is now accepted and ready to land.Feb 24 2023, 2:43 PM

Closed by commit rG07ccf71451d7: bcm_dma: don't dereference NULL softc (authored by mhorne). · Explain WhyFeb 24 2023, 5:24 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG07ccf71451d7: bcm_dma: don't dereference NULL softc.

mhorne added a commit: rGaa399ad3e554: bcm_dma: don't dereference NULL softc.Mar 7 2023, 4:56 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

broadcom/

bcm2835/

bcm2835_dma.c

29 lines

Diff 117883

View Options

sys/arm/broadcom/bcm2835/bcm2835_dma.c

bcm_dma: don't dereference NULL softcClosedPublicActions