Page MenuHomeFreeBSD

jail: Fix redoing ip restricting
ClosedPublic

Authored by zlei on Feb 20 2023, 3:21 PM.
Tags
None
Referenced Files
F171542825: D38697.id117699.diff
Fri, Sep 11, 4:19 PM
Unknown Object (File)
Fri, Sep 11, 2:43 AM
Unknown Object (File)
Fri, Sep 11, 12:36 AM
Unknown Object (File)
Thu, Sep 10, 11:24 AM
Unknown Object (File)
Thu, Sep 10, 7:15 AM
Unknown Object (File)
Wed, Sep 9, 12:53 AM
Unknown Object (File)
Mon, Sep 7, 4:22 PM
Unknown Object (File)
Fri, Sep 4, 11:28 PM
Subscribers

Details

Summary

prison_ip_restrict() is called in loop FOREACH_PRISON_DESCENDANT_LOCKED. While under low memory, it is still possible that subsequent round prison_ip_restrict() succeed and redo_ip[4,6] flip over from true to false, thus leave some prisons's IPv[4,6] addresses unrestricted.

Fixes: 8bce8d28abe6 jail: Avoid multipurpose return value of function prison_ip_restrict()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Feb 20 2023, 3:21 PM

This makes perfect sense to me. The original version only set redo_ip[46] provisionally , and I missed that the patch changed that.

This revision is now accepted and ready to land.Feb 20 2023, 7:14 PM
This revision was automatically updated to reflect the committed changes.