Page MenuHomeFreeBSD

jail: Fix redoing ip restricting
ClosedPublic

Authored by zlei on Feb 20 2023, 3:21 PM.
Tags
None
Referenced Files
F161091258: D38697.diff
Tue, Jun 30, 11:49 AM
Unknown Object (File)
Thu, Jun 25, 12:55 AM
Unknown Object (File)
Wed, Jun 24, 4:49 PM
Unknown Object (File)
Tue, Jun 9, 8:08 PM
Unknown Object (File)
May 16 2026, 8:21 AM
Unknown Object (File)
May 15 2026, 11:25 PM
Unknown Object (File)
May 15 2026, 11:25 PM
Unknown Object (File)
May 15 2026, 11:23 PM
Subscribers

Details

Summary

prison_ip_restrict() is called in loop FOREACH_PRISON_DESCENDANT_LOCKED. While under low memory, it is still possible that subsequent round prison_ip_restrict() succeed and redo_ip[4,6] flip over from true to false, thus leave some prisons's IPv[4,6] addresses unrestricted.

Fixes: 8bce8d28abe6 jail: Avoid multipurpose return value of function prison_ip_restrict()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Feb 20 2023, 3:21 PM

This makes perfect sense to me. The original version only set redo_ip[46] provisionally , and I missed that the patch changed that.

This revision is now accepted and ready to land.Feb 20 2023, 7:14 PM
This revision was automatically updated to reflect the committed changes.