Page MenuHomeFreeBSD
Differential D3857

Switch pl_child_pid from int to pid_t.
ClosedPublic
Actions

Authored by jhb on Oct 9 2015, 4:22 PM.
Tags
None
Referenced Files
F132423345: D3857.diff
Thu, Oct 16, 7:43 PM
Unknown Object (File)
Tue, Oct 14, 10:07 AM
Unknown Object (File)
Sun, Oct 12, 3:01 PM
Unknown Object (File)
Sun, Oct 12, 1:08 PM
Unknown Object (File)
Thu, Oct 9, 10:55 AM
Unknown Object (File)
Mon, Oct 6, 11:55 AM
Unknown Object (File)
Mon, Oct 6, 4:38 AM
Unknown Object (File)
Sun, Oct 5, 10:22 PM
View All 85 Files
Subscribers
emaste
imp

Details

Reviewers
kib
emaste
Group Reviewers
manpages
Commits
rS289636: Switch pl_child_pid from int to pid_t.
Summary

Switch pl_child_pid from int to pid_t.

Test Plan
  • make universe passed
  • verified with gdb that size of ptrace_lwpinfo and offset of pl_syscall_code were identical for old and new binaries

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 9281.Oct 9 2015, 4:22 PM
jhb retitled this revision from to Switch pl_child_pid from int to pid_t..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
Herald added a reviewer: manpages. · View Herald TranscriptOct 9 2015, 4:22 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
emaste accepted this revision.Oct 9 2015, 5:06 PM
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Oct 9 2015, 5:06 PM
kib accepted this revision.Oct 10 2015, 5:56 AM
kib edited edge metadata.

I think that I used int because it is more explicit for ABI. But since the struct ptrace_lwpinfo is not 32/64 bit invariant, this is moot.

Closed by commit rS289636: Switch pl_child_pid from int to pid_t. (authored by jhb). · Explain WhyOct 20 2015, 5:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
sys/
4 lines
sys/
kern/
2 lines
sys/
2 lines

Diff 9546

View Options

head/lib/libc/sys/ptrace.2

Loading...
View Options

head/sys/kern/sys_process.c

Loading...
View Options

head/sys/sys/ptrace.h

Loading...