Page MenuHomeFreeBSD

Switch pl_child_pid from int to pid_t.
ClosedPublic

Authored by jhb on Oct 9 2015, 4:22 PM.
Tags
None
Referenced Files
F132423345: D3857.diff
Thu, Oct 16, 7:43 PM
Unknown Object (File)
Tue, Oct 14, 10:07 AM
Unknown Object (File)
Sun, Oct 12, 3:01 PM
Unknown Object (File)
Sun, Oct 12, 1:08 PM
Unknown Object (File)
Thu, Oct 9, 10:55 AM
Unknown Object (File)
Mon, Oct 6, 11:55 AM
Unknown Object (File)
Mon, Oct 6, 4:38 AM
Unknown Object (File)
Sun, Oct 5, 10:22 PM
Subscribers

Details

Summary

Switch pl_child_pid from int to pid_t.

Test Plan
  • make universe passed
  • verified with gdb that size of ptrace_lwpinfo and offset of pl_syscall_code were identical for old and new binaries

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb retitled this revision from to Switch pl_child_pid from int to pid_t..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Oct 9 2015, 5:06 PM
kib edited edge metadata.

I think that I used int because it is more explicit for ABI. But since the struct ptrace_lwpinfo is not 32/64 bit invariant, this is moot.

This revision was automatically updated to reflect the committed changes.