Page MenuHomeFreeBSD
Differential D38560

ofed: Mechanically convert to IfAPI
ClosedPublic
Actions

Authored by jhibbits on Feb 13 2023, 6:43 PM.
Tags
None
Referenced Files
F149760077: D38560.diff
Thu, Mar 26, 8:51 PM
Unknown Object (File)
Wed, Mar 18, 5:22 PM
Unknown Object (File)
Wed, Mar 18, 1:18 PM
Unknown Object (File)
Wed, Mar 18, 10:21 AM
Unknown Object (File)
Wed, Mar 18, 4:18 AM
Unknown Object (File)
Tue, Mar 17, 8:01 PM
Unknown Object (File)
Tue, Mar 10, 4:19 PM
Unknown Object (File)
Sun, Mar 8, 7:17 PM
View All Files
Subscribers
imp

Details

Reviewers
glebius
• hselasky
Group Reviewers
network
Commits
rG3e142e07675b: ofed: Mechanically convert to IfAPI
Summary

Because of the intricacies of this code it wasn't purely scripted, but
instead hand-mechanical.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Feb 13 2023, 6:43 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2023, 6:43 PM
jhibbits requested review of this revision.Feb 13 2023, 6:43 PM
Harbormaster completed remote builds in B49742: Diff 117111.Feb 13 2023, 6:43 PM
jhibbits updated this revision to Diff 119349.Mar 23 2023, 5:48 PM

Update to use the new if_iter API. Remove rest of struct ifnet uses in the code.

Harbormaster completed remote builds in B50546: Diff 119349.Mar 23 2023, 5:48 PM
• hselasky accepted this revision.Mar 23 2023, 6:33 PM

Looks pretty good to me. If any issues pop up I know one commit to look at :-)

One idea that comes to mind:
if_getdrvflags(dev) & IFF_DRV_OACTIVE

Instead of doing bit-tests, maybe we should convert those flags to enums, so that we query a flag based on an enum. Then there can be more than 32-64 flags ...

This revision is now accepted and ready to land.Mar 23 2023, 6:33 PM
Closed by commit rG3e142e07675b: ofed: Mechanically convert to IfAPI (authored by jhibbits). · Explain WhyMar 24 2023, 3:49 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG3e142e07675b: ofed: Mechanically convert to IfAPI.

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
10 lines
88 lines
26 lines
6 lines
74 lines
12 lines
2 lines
152 lines
6 lines
ulp/
ipoib/
10 lines
36 lines
16 lines
4 lines
26 lines
201 lines
20 lines
8 lines
10 lines
include/
rdma/
43 lines
12 lines
4 lines
4 lines
10 lines

Diff 119400

View Options

sys/ofed/drivers/infiniband/core/core_priv.h

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_addr.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cache.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cm.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cma.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_device.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_multicast.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_sa_query.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib.h

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_fs.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_multicast.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_vlan.c

Loading...
View Options

sys/ofed/include/rdma/ib_addr.h

Loading...
View Options

sys/ofed/include/rdma/ib_addr_freebsd.h

Loading...
View Options

sys/ofed/include/rdma/ib_cache.h

Loading...
View Options

sys/ofed/include/rdma/ib_sa.h

Loading...
View Options

sys/ofed/include/rdma/ib_verbs.h

Loading...