Page MenuHomeFreeBSD
Differential D38462

devel/appstream-qt: Create a port for Qt bindings to AppStream library. Sponsored by: Serenity Cybersecurity, LLC
ClosedPublic
Actions

Authored by arrowd on Feb 9 2023, 1:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 12:14 PM
Unknown Object (File)
Thu, May 2, 3:18 AM
Unknown Object (File)
Thu, Apr 25, 9:38 PM
Unknown Object (File)
Fri, Apr 12, 10:55 AM
Unknown Object (File)
Fri, Apr 12, 10:37 AM
Unknown Object (File)
Mar 18 2024, 7:42 PM
Unknown Object (File)
Mar 18 2024, 7:42 PM
Unknown Object (File)
Mar 18 2024, 7:41 PM
View All 29 Files
Subscribers
mat
tcberner

Details

Reviewers
tcberner
Group Reviewers
Contributor Reviewers (ports)
desktop
Commits
R11:43f1b2df21bf: devel/appstream-qt: Create a port for Qt bindings to AppStream library.
Test Plan

poduriere testport on 14-CURRENT

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49648
Build 46538: arc lint + arc unit

Event Timeline

arrowd created this revision.Feb 9 2023, 1:40 PM
Herald added a subscriber: mat. · View Herald TranscriptFeb 9 2023, 1:40 PM
arrowd requested review of this revision.Feb 9 2023, 1:40 PM
Harbormaster completed remote builds in B49648: Diff 116842.Feb 9 2023, 1:40 PM
tcberner accepted this revision.Feb 13 2023, 12:18 PM
tcberner added a subscriber: tcberner.

some minor suggestion on line 17, 23 and 30, other wise, I guess it looks fine :)

devel/appstream-qt/Makefile
1

^ I think -qt would be more canonical? -- never mind, the master port is AppStream oO and not appstream :)

devel/appstream/Makefile
17

the ?= and += might be a bit confusing if one does not know about the existence of the slave-port.
Maybe consider to add a comment ala

# overriden by devel/appstream-qt

etc ?

This revision is now accepted and ready to land.Feb 13 2023, 12:18 PM
Closed by commit R11:43f1b2df21bf: devel/appstream-qt: Create a port for Qt bindings to AppStream library. (authored by arrowd). · Explain WhyFeb 13 2023, 12:42 PM
This revision was automatically updated to reflect the committed changes.
arrowd marked 2 inline comments as done.
arrowd added a commit: R11:43f1b2df21bf: devel/appstream-qt: Create a port for Qt bindings to AppStream library..

Revision Contents
Changeset List

PathSize
devel/
1 line
appstream-qt/
22 lines
26 lines
appstream/
10 lines

Diff 116842

View Options

devel/Makefile

Loading...
View Options

devel/appstream-qt/Makefile

Loading...
View Options

devel/appstream-qt/pkg-plist

Loading...
View Options

devel/appstream/Makefile

Loading...