Paths

Table of Contentst

Differential D38462

devel/appstream-qt: Create a port for Qt bindings to AppStream library. Sponsored by: Serenity Cybersecurity, LLC
ClosedPublic
Actions

Authored by arrowd on Feb 9 2023, 1:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 13, 3:50 AM

	Unknown Object (File)
	Sun, Oct 12, 4:18 PM

	Unknown Object (File)
	Sat, Oct 4, 10:47 AM

	Unknown Object (File)
	Thu, Oct 2, 9:57 AM

	Unknown Object (File)
	Thu, Oct 2, 7:41 AM

	Unknown Object (File)
	Wed, Oct 1, 7:39 PM

	Unknown Object (File)
	Wed, Oct 1, 7:01 PM

	Unknown Object (File)
	Wed, Oct 1, 2:08 PM

Subscribers

Details

Reviewers

Group Reviewers

Contributor Reviewers (ports)
desktop

Commits

R11:43f1b2df21bf: devel/appstream-qt: Create a port for Qt bindings to AppStream library.

Test Plan

poduriere testport on 14-CURRENT

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arrowd created this revision.Feb 9 2023, 1:40 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 9 2023, 1:40 PM

arrowd requested review of this revision.Feb 9 2023, 1:40 PM

Harbormaster completed remote builds in B49648: Diff 116842.Feb 9 2023, 1:40 PM

some minor suggestion on line 17, 23 and 30, other wise, I guess it looks fine :)

devel/appstream-qt/Makefile
2	^ I think `-qt` would be more canonical? -- never mind, the master port is `AppStream` oO and not `appstream` :)
devel/appstream/Makefile
20	the `?=` and `+=` might be a bit confusing if one does not know about the existence of the slave-port. Maybe consider to add a comment ala # overriden by devel/appstream-qt etc ?

This revision is now accepted and ready to land.Feb 13 2023, 12:18 PM

Closed by commit R11:43f1b2df21bf: devel/appstream-qt: Create a port for Qt bindings to AppStream library. (authored by arrowd). · Explain WhyFeb 13 2023, 12:42 PM

This revision was automatically updated to reflect the committed changes.

arrowd marked 2 inline comments as done.

arrowd added a commit: R11:43f1b2df21bf: devel/appstream-qt: Create a port for Qt bindings to AppStream library..

Revision Contents
Changeset List

Path

Size

devel/

1 line

appstream-qt/

22 lines

26 lines

appstream/

13 lines

Diff 117086

devel/Makefile

Loading...

devel/appstream-qt/Makefile

Loading...

devel/appstream-qt/pkg-plist

Loading...

devel/appstream/Makefile

Loading...