Page MenuHomeFreeBSD

free export structures when a file system is dismounted
ClosedPublic

Authored by rmacklem on Feb 4 2023, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 7:25 PM
Unknown Object (File)
Sun, May 24, 3:48 PM
Unknown Object (File)
Thu, May 21, 6:24 PM
Unknown Object (File)
Wed, May 6, 11:06 PM
Unknown Object (File)
Sat, May 2, 4:58 AM
Unknown Object (File)
Apr 20 2026, 2:47 PM
Unknown Object (File)
Apr 20 2026, 1:31 PM
Unknown Object (File)
Apr 9 2026, 6:32 PM
Subscribers

Details

Summary

During testing of exporting file systems in jails, I
noticed that the export structures on a mount
were not being free'd when the mount is dismounted.

This bug appears to have been in the system for a
very long time. It would have resulted in a slow memory
leak when exported file systems were dismounted.

Prior to r362158, freeing the structures during dismount
would not have been safe, since VFS_CHECKEXP() returned
a pointer into an export structure, which might still be used
by the NFS server for an in-progress RPC when the file system
is dismounted. r362158 fixed this, so it should now be safe
to free the structures in vfs_mount_destroy(), which is what
this patch does.

Test Plan

Monitored export structure allocation via "vmstat -m"
before and after doing a umount of an exported file
system.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable