Add support for a new Raptor Lake card.
PR: 269224
Details
Details
- Reviewers
erj - Group Reviewers
Intel Networking - Commits
- rGc0548bfc3a09: em(4): Add IDs for new Intel(R) I219 devices
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The PR mentions only this one, the others were probably not tested. Do you think it would be appriopriate to add them anyway?
Comment Actions
Yes. One issue though with just adding the device IDs is that some of these may have minor hardware changes that have software adjustments that may need to be added, but that would apply more to (22) than something like (20). But if the driver works on (22), just having the device IDs of everything before that is still a good start. Plus, all of those missing devices all belong to this driver, anyway.
Comment Actions
so can this be sorted out? note there is a release start pending soon, would be nice to get this in
no hardware to test on on my end, so this is just a nagging comment :)
| sys/dev/e1000/e1000_api.c | ||
|---|---|---|
| 335 | We should add the device IDs for (23) devices, and assign them a MAC type here, too. Those also look like Raptor Lake-era ones. | |
| 336 | Interestingly, it looks like the (16) devices got moved to the section before, so that they should be "e1000_pch_tgp" instead of "e1000_pch_adp". | |
| sys/dev/e1000/e1000_api.c | ||
|---|---|---|
| 347 | The (23) devices need to go in the tgp section and not adp, weirdly. It's odd. | |