cp: Minor code cleanup.
ClosedPublic
Actions

Authored by des on Feb 3 2023, 11:32 AM.

Details

Reviewers

allanjude

Group Reviewers

Klara

Commits

rGcb96a0ef0040: cp: Minor code cleanup.

Summary

Fix includes in utils.c, cf. style(9).
Fix type mismatch: readlink(2) returns ssize_t, not int.
It is not necessary to set errno to 0 as fts_read(3) already does it.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Feb 3 2023, 11:32 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2023, 11:32 AM

des requested review of this revision.Feb 3 2023, 11:32 AM

Harbormaster completed remote builds in B49505: Diff 116386.Feb 3 2023, 11:32 AM

des retitled this revision from cp: Clean up includes. to cp: Minor code cleanup..Feb 3 2023, 12:12 PM

Additional cleanup.

Harbormaster completed remote builds in B49506: Diff 116387.Feb 3 2023, 12:13 PM

des edited the summary of this revision. (Show Details)Feb 3 2023, 12:14 PM

Reviewed by: allanjude

This revision is now accepted and ready to land.Feb 3 2023, 1:49 PM

Closed by commit rGcb96a0ef0040: cp: Minor code cleanup. (authored by des). · Explain WhyFeb 3 2023, 3:38 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGcb96a0ef0040: cp: Minor code cleanup..

des mentioned this in rGd6d22a4530f9: cp: Add tests involving sparse files..Feb 9 2023, 8:41 PM

Revision Contents
Changeset List

Path

Size

bin/

cp/

cp.c

3 lines

utils.c

5 lines

Diff 116396

View Options

bin/cp/cp.c