riscv: implement dtrace_getustackdepth()
ClosedPublic
Actions

Authored by mhorne on Jan 31 2023, 7:51 PM.

Details

Reviewers

markj
jrtc27
gnn

Group Reviewers

riscv

Commits

rG3b0fb298fec6: dtrace: implement riscv dtrace_getustackdepth()
rGc6943b44f7d7: dtrace: implement riscv dtrace_getustackdepth()

Summary

Pretty trivial following other implementations. The existing
dtrace_getustack_common() does most of the work.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jan 31 2023, 7:51 PM

Herald added a reviewer: gnn. · View Herald TranscriptJan 31 2023, 7:51 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Jan 31 2023, 7:51 PM

Harbormaster completed remote builds in B49365: Diff 116120.Jan 31 2023, 7:51 PM

markj added inline comments.Feb 1 2023, 3:05 PM

sys/cddl/dev/dtrace/riscv/dtrace_isa.c
243	`sp` appears to be unused?

Remove set-but-unused sp. Do the same for dtrace_getupcstack().

Harbormaster completed remote builds in B49479: Diff 116333.Feb 2 2023, 2:37 PM

markj accepted this revision.Feb 2 2023, 2:41 PM

This revision is now accepted and ready to land.Feb 2 2023, 2:41 PM

Closed by commit rGc6943b44f7d7: dtrace: implement riscv dtrace_getustackdepth() (authored by mhorne). · Explain WhyFeb 6 2023, 7:30 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGc6943b44f7d7: dtrace: implement riscv dtrace_getustackdepth().

mhorne added a commit: rG3b0fb298fec6: dtrace: implement riscv dtrace_getustackdepth().Feb 15 2023, 4:45 PM

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

dtrace/

riscv/

dtrace_isa.c

31 lines

Diff 116633

View Options

sys/cddl/dev/dtrace/riscv/dtrace_isa.c

riscv: implement dtrace_getustackdepth()ClosedPublicActions