Page MenuHomeFreeBSD

Improve the style in one of the examples.
ClosedPublic

Authored by pjd on Jan 31 2023, 12:11 AM.
Tags
None
Referenced Files
F83193915: D38287.diff
Tue, May 7, 1:32 PM
Unknown Object (File)
Sat, Apr 20, 6:44 PM
Unknown Object (File)
Sat, Apr 20, 6:02 AM
Unknown Object (File)
Mar 21 2024, 3:45 AM
Unknown Object (File)
Feb 11 2024, 1:42 AM
Unknown Object (File)
Feb 1 2024, 8:00 AM
Unknown Object (File)
Jan 19 2024, 4:41 AM
Unknown Object (File)
Dec 20 2023, 5:46 AM
Subscribers

Details

Summary

Improve the style in one of the examples.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

pjd requested review of this revision.Jan 31 2023, 12:11 AM
pjd created this revision.

The diffs should be generated with the full context:

git diff -U99999

You can also try using git-arc:
https://github.com/markjdb/scripts/blob/master/git-arc

It simplifies work with phabricator.

The patch LGTM, please remember to bump .Dd.

This revision is now accepted and ready to land.Jan 31 2023, 12:43 AM

One more thing.
I'm not sure what commit msg you want to use.
So as a side note, many people give in the first line a oneliner containing the module/subsystem name and a meaningful description.
So for this case, you can use the following:

nv: improve the style in one of the examples

or

libnv: improve the style in one of the examples

approved by: allanjude

Remember to update the .Dd like Mariusz said

This revision was automatically updated to reflect the committed changes.