Remove redundant RFFPWAIT handling in Linux fork(2) and clone(2) handlers.
ClosedPublic
Actions

Authored by bdrewery on Oct 6 2015, 5:39 PM.

Details

Reviewers

kib
jhb

Commits

rS288994: Remove redundant RFFPWAIT/vfork(2) handling in Linux fork(2) and clone(2)…

Summary

r161611 added some of the code from sys_vfork() directly into the Linux
module wrappers. In r232240, the RFFPWAIT handling was moved to syscallret(),
thus this code in the Linux module is no longer needed as it will be called
in the proper order already.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery updated this revision to Diff 9186.Oct 6 2015, 5:39 PM

bdrewery retitled this revision from to Remove redundant RFFPWAIT handling in Linux fork(2) and clone(2) handlers..

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

bdrewery added reviewers: kib, jhb.

bdrewery added a subscriber: dchagin.

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2015, 5:39 PM

Also set td_retval[1] = 0, as the main sys_*fork() syscalls do.

Remove retval change. May not be proper for Linux calling conventions.

I think this looks ok.

This revision is now accepted and ready to land.Oct 6 2015, 9:05 PM

kib accepted this revision.Oct 7 2015, 6:41 AM

kib edited edge metadata.

Closed by commit rS288994: Remove redundant RFFPWAIT/vfork(2) handling in Linux fork(2) and clone(2)… (authored by bdrewery). · Explain WhyOct 7 2015, 7:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

linux_fork.c

33 lines

Diff 9222

View Options

head/sys/compat/linux/linux_fork.c

Remove redundant RFFPWAIT handling in Linux fork(2) and clone(2) handlers.ClosedPublicActions