Page MenuHomeFreeBSD

Group the decoded system calls by ABI and sort the calls within each ABI.
ClosedPublic

Authored by jhb on Oct 6 2015, 2:33 AM.
Tags
None
Referenced Files
F105876514: D3823.id9179.diff
Sat, Dec 21, 11:46 PM
Unknown Object (File)
Sun, Nov 24, 1:14 AM
Unknown Object (File)
Nov 18 2024, 6:53 AM
Unknown Object (File)
Oct 17 2024, 11:32 AM
Unknown Object (File)
Sep 28 2024, 7:00 AM
Unknown Object (File)
Sep 28 2024, 12:52 AM
Unknown Object (File)
Sep 28 2024, 12:13 AM
Unknown Object (File)
Sep 27 2024, 1:22 PM
Subscribers

Details

Summary

Group the decoded system calls by ABI and sort the calls within each ABI.

I originally was just going to use a single sorted list, but I think it
is better to group the calls by ABI. Once I make a first pass adding more
decodings for the native ABI I plan to add decoding for freebsd32 to match
all the calls handled in the native ABI.

Test Plan
  • Compared truss output of my system call exerciser for amd64 and i386 binaries under amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb retitled this revision from to Group the decoded system calls by ABI and sort the calls within each ABI..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added reviewers: kib, bdrewery.

I never realized how truss matches syscall to the table. Doing it by name is somewhat ridiculous, but I see the point.

If you keep the table ordered alphabetically, you could use binary search instead of linear.

In D3823#78888, @kib wrote:

I never realized how truss matches syscall to the table. Doing it by name is somewhat ridiculous, but I see the point.

If you keep the table ordered alphabetically, you could use binary search instead of linear.

This table isn't used for searching anymore. It's in a separate dynamic list which has unknown syscalls added to it as discovered. I'm working on making that list into a hash table.

bdrewery edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2015, 4:46 PM
This revision was automatically updated to reflect the committed changes.