Page MenuHomeFreeBSD

netlink: Zero-initialize writer structures allocated on the stack
ClosedPublic

Authored by markj on Jan 26 2023, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 2:06 AM
Unknown Object (File)
Sun, Feb 23, 11:48 PM
Unknown Object (File)
Jan 19 2025, 11:55 PM
Unknown Object (File)
Jan 19 2025, 2:22 AM
Unknown Object (File)
Jan 12 2025, 6:43 AM
Unknown Object (File)
Jan 11 2025, 2:00 AM
Unknown Object (File)
Jan 10 2025, 11:05 PM
Unknown Object (File)
Nov 21 2024, 6:44 AM
Subscribers

Details

Summary

The prevailing pattern seems to be to simply initialize all fields to
zero. Without this, it's possible to trigger a branch on uninitialized
memory. Specifically, when testing nw->ignore_limit in
nlmsg_refill_buffer().

Initialize the writer structure in a couple of functions where this is
necessary.

Reported by: KMSAN

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 26 2023, 3:07 PM

Ack, that's a good one!
My initial approach was to perform zero in the -> init() functions (e.g. nlmsg_get_ns_<mbuf|lbuf|buf>), preferably via explicit field initialisation. Apparently the latter one has failed.
ATM I'm leaning towards doing the explicit bzero() in all init functions, but need to think a bit more about it.
To unblock the fix, let's require the explicit writer initialisation for now.

This revision is now accepted and ready to land.Jan 26 2023, 3:24 PM