Integrate tools/regression/acltools into the FreeBSD test suite as tests/sys/acl

[ngie]

Summary

Integrate tools/regression/acltools into the FreeBSD test suite as tests/sys/acl

The goals of the integration, as a first step, is to integrate the testcases into
the FreeBSD test suite as close to the current state for the testcases.

The changes that I made on GitHub that I've ported here do the following:

• Make the requirements more complete for the testcases
• Detect prerequisites so the tests won't fail (zpool, ACL support is enabled with UFS, etc).
• Work with temporary files/directories/mountpoints that work with atf/kyua
• Limit the testcases to work on temporary filesystems to reduce tainting the test host

Note: Phabricator's not being nice with the diff. Here's the complete initial
change: https://svnweb.freebsd.org/changeset/base/288680 .

Sponsored by: EMC / Isilon Storage Division

[trasz]

I like the idea. But it looks like you've moved the 'XX.t' files, but deleted the 'run' script and the actual tests ('*.test'). How does it work?

[trasz]

... or is it perhaps just my poor understanding how this diff thing works. So, assuming the stuff is all there - why did you remove unmounting from eg 00.t after the test is done? Is the "Bail out" comment some kind of debugging printf?

[ngie]

In D3810#79386, @trasz wrote:

I like the idea. But it looks like you've moved the 'XX.t' files, but deleted the 'run' script and the actual tests ('*.test'). How does it work?

• The .t files were moved to .sh files for consistency with the other prove integration jmmv and I have done in the past.
• The run script is still there: https://svnweb.freebsd.org/base/user/ngie/more-tests/tests/sys/acl/run?view=log&pathrev=288680 .

Seems like Phabricator is sensitive to multiple file changes in a single diff.

[trasz]

Ok. So, why did you remove unmounting from eg 00.t after the test is done? Is the "Bail out" comment some kind of debugging printf?

[ngie]

In D3810#80436, @trasz wrote:

Ok. So, why did you remove unmounting from eg 00.t after the test is done? Is the "Bail out" comment some kind of debugging printf?

• I'll look double-check, but the reason why (IIRC) was some of the exit paths were impacted by the fact that kyua goes and cleans up mount points after the fact.
• "Bail out" tells TAP that the test script is aborting due to an abnormal failure: https://testanything.org/tap-specification.html (look for "

[ngie]

In D3810#80448, @ngie wrote:

In D3810#80436, @trasz wrote:

Ok. So, why did you remove unmounting from eg 00.t after the test is done? Is the "Bail out" comment some kind of debugging printf?

• I'll look double-check, but the reason why (IIRC) was some of the exit paths were impacted by the fact that kyua goes and cleans up mount points after the fact.
• "Bail out" tells TAP that the test script is aborting due to an abnormal failure: https://testanything.org/tap-specification.html (look for "

look for "Bail out"