Differential D38091

Improve debuggability of VOP_* locking assertions
ClosedPublic
Actions

Authored by jah on Jan 16 2023, 9:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 12, 12:14 AM

	Unknown Object (File)
	Tue, Sep 8, 2:54 PM

	Unknown Object (File)
	Sat, Sep 5, 11:20 PM

	Unknown Object (File)
	Sat, Sep 5, 5:55 PM

	Unknown Object (File)
	Sat, Sep 5, 2:25 AM

	Unknown Object (File)
	Thu, Sep 3, 3:05 PM

	Unknown Object (File)
	Wed, Sep 2, 5:33 PM

	Unknown Object (File)
	Wed, Sep 2, 5:02 PM

Subscribers

Details

Reviewers

kib
markj
mjg

Commits

rG5a4a83fd0e67: Improve debuggability of VOP_* locking assertions

Summary

Include the phase and argument field to make it easier to determine
at a glance where the failure originated.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jah created this revision.Jan 16 2023, 9:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2023, 9:41 PM

jah requested review of this revision.Jan 16 2023, 9:41 PM

Harbormaster completed remote builds in B49136: Diff 115215.Jan 16 2023, 9:41 PM

Could you please show an example of the new output?

In D38091#865308, @kib wrote:

Could you please show an example of the new output?

This is what I saw a few hours ago when I used it to help me debug a unionfs issue:

VOP_MKDIR Error (dvp): vnode <...> is not exclusive locked but should be

kib accepted this revision.Jan 17 2023, 12:27 AM

This revision is now accepted and ready to land.Jan 17 2023, 12:27 AM

markj accepted this revision.Jan 18 2023, 3:52 PM

Closed by commit rG5a4a83fd0e67: Improve debuggability of VOP_* locking assertions (authored by jah). · Explain WhyJan 19 2023, 3:59 AM

This revision was automatically updated to reflect the committed changes.

jah added a commit: rG5a4a83fd0e67: Improve debuggability of VOP_* locking assertions.

Revision Contents
Changeset List

Path

Size

sys/

tools/

8 lines

Diff 115298

sys/tools/vnode_if.awk

Loading...