tzcode: Avoid memory leak if pthread_setspecific() fails.
ClosedPublic
Actions

Authored by des on Jan 13 2023, 3:24 PM.

Details

Reviewers

emaste
imp
kevans

Group Reviewers

Klara

Commits

rG96e68c393f65: tzcode: Avoid memory leak if pthread_setspecific() fails.

Summary

Reported by: Coverity (CID 1018472, 1018474)
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jan 13 2023, 3:24 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 13 2023, 3:24 PM

des requested review of this revision.Jan 13 2023, 3:24 PM

des added a parent revision: D38035: tzcode: Remove access() again, cf. 02ba1d993fa9..

des added a child revision: D38037: tzcode: Fully initialize structs before use..

Harbormaster completed remote builds in B49084: Diff 115037.Jan 13 2023, 3:24 PM

This looks fine, but I'd suggest a better commit message explaining the Coverity issues would be helpful

This revision is now accepted and ready to land.Jan 13 2023, 4:35 PM

In D38036#864270, @imp wrote:

This looks fine, but I'd suggest a better commit message explaining the Coverity issues would be helpful

What needs explaining? Coverity correctly flagged that the code doesn't check the outcome of the _pthread_setspecific() calls, so I added checks.

kevans accepted this revision.Jan 13 2023, 9:52 PM

In D38036#864286, @des wrote:

What needs explaining? Coverity correctly flagged that the code doesn't check the outcome of the _pthread_setspecific() calls, so I added checks.

Agreed, checking for failure seems self-explanatory.

In D38036#864475, @emaste wrote:

In D38036#864286, @des wrote:

What needs explaining? Coverity correctly flagged that the code doesn't check the outcome of the _pthread_setspecific() calls, so I added checks.

Agreed, checking for failure seems self-explanatory.

Check outcome and cleanup on failure then. Since it's more than just a check and return...

Again, just a suggestion to make it better...

des retitled this revision from tzcode: Check outcome of pthread_getspecific(). to tzcode: Avoid memory leak if pthread_getspecific() fails..Jan 14 2023, 4:40 PM

des retitled this revision from tzcode: Avoid memory leak if pthread_getspecific() fails. to tzcode: Avoid memory leak if pthread_setspecific() fails..

Closed by commit rG96e68c393f65: tzcode: Avoid memory leak if pthread_setspecific() fails. (authored by des). · Explain WhyJan 14 2023, 5:20 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG96e68c393f65: tzcode: Avoid memory leak if pthread_setspecific() fails..

des mentioned this in rG93cc70bf9ca7: Bring our tzcode up to date..Jan 31 2023, 9:48 AM