Page MenuHomeFreeBSD

Update icingaweb2 to 2.11.3
ClosedPublic

Authored by joneum on Jan 10 2023, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 5:28 PM
Unknown Object (File)
Fri, Dec 6, 9:54 AM
Unknown Object (File)
Nov 25 2024, 5:18 AM
Unknown Object (File)
Nov 24 2024, 6:06 PM
Unknown Object (File)
Nov 24 2024, 8:09 AM
Unknown Object (File)
Nov 23 2024, 7:59 AM
Unknown Object (File)
Nov 22 2024, 9:42 PM
Unknown Object (File)
Nov 22 2024, 2:11 PM
Subscribers

Details

Summary

Icingaweb now uses Icinga-php-library, formerly icingaweb2-module-ipl, to build it.
The last, currently disabled block caused error messages. The block was used to automatically create the config.
Can I write it in the pkg-message so that the user creates this himself from now on?

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The files will of course be cleaned before commit :)

net-mgmt/icingaweb2/Makefile
40

^already present on line 32

net-mgmt/icingaweb2/pkg-plist
2581–2582

^ why is that not at the end?

2 fixed found from tcberner

net-mgmt/icingaweb2/Makefile
14

s/RUB/RUN/

net-mgmt/icingaweb2/pkg-message.in
2 ↗(On Diff #114938)

Are users that upgrade net-mgmt/icingaweb2 also affected by this? If so, maybe an additional type: upgrade entry along with maximum_version makes sense then. To cover all eventualities, an entry in UPDATING should also be created.

4 ↗(On Diff #114938)

s/For/To/

flo requested changes to this revision.Jan 20 2023, 1:44 PM
flo added a subscriber: flo.

Please do not commit this version. Was this run tested at all? I just tried this patch and it immediately failed with one of the errors that's fixed in my patches provided in PR 263115.

Fatal error: Trait "ipl\I18n\Translation" not found in /usr/local/www/icingaweb2/library/Icinga/Web/View.php on line 55

And that's not the only one that will happen. My patch has been used to update a production instance and I also tested setting up a new instance.

It also addresses the web server configuration in an easy way for the user using pkg-message

Please review and approve my patches in 263115. I'd also be happy to create a review here, in case I missed anything in my patches.

Thanks
Florian

This revision now requires changes to proceed.Jan 20 2023, 1:44 PM
In D38018#866313, @flo wrote:

Please do not commit this version. Was this run tested at all? I just tried this patch and it immediately failed with one of the errors that's fixed in my patches provided in PR 263115.

Fatal error: Trait "ipl\I18n\Translation" not found in /usr/local/www/icingaweb2/library/Icinga/Web/View.php on line 55

And that's not the only one that will happen. My patch has been used to update a production instance and I also tested setting up a new instance.

It also addresses the web server configuration in an easy way for the user using pkg-message

Please review and approve my patches in 263115. I'd also be happy to create a review here, in case I missed anything in my patches.

Thanks
Florian

Relax, Flo :-)
That should only show you that I also worked on an update. All good. I will look at your patch. it looks good :-)

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 23 2023, 2:09 PM
This revision was automatically updated to reflect the committed changes.