Icingaweb now uses Icinga-php-library, formerly icingaweb2-module-ipl, to build it.
The last, currently disabled block caused error messages. The block was used to automatically create the config.
Can I write it in the pkg-message so that the user creates this himself from now on?
Details
- Reviewers
tcberner lme kai flo - Commits
- R11:8295feba03e1: net-mgmt/icingaweb2: Update to 2.11.3
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
net-mgmt/icingaweb2/Makefile | ||
---|---|---|
14 | s/RUB/RUN/ | |
net-mgmt/icingaweb2/pkg-message.in | ||
2 ↗ | (On Diff #114938) | Are users that upgrade net-mgmt/icingaweb2 also affected by this? If so, maybe an additional type: upgrade entry along with maximum_version makes sense then. To cover all eventualities, an entry in UPDATING should also be created. |
4 ↗ | (On Diff #114938) | s/For/To/ |
Please do not commit this version. Was this run tested at all? I just tried this patch and it immediately failed with one of the errors that's fixed in my patches provided in PR 263115.
Fatal error: Trait "ipl\I18n\Translation" not found in /usr/local/www/icingaweb2/library/Icinga/Web/View.php on line 55
And that's not the only one that will happen. My patch has been used to update a production instance and I also tested setting up a new instance.
It also addresses the web server configuration in an easy way for the user using pkg-message
Please review and approve my patches in 263115. I'd also be happy to create a review here, in case I missed anything in my patches.
Thanks
Florian
Relax, Flo :-)
That should only show you that I also worked on an update. All good. I will look at your patch. it looks good :-)