)bitstring.h
ClosedPublic
Actions

Authored by brooks on Jan 4 2023, 11:38 PM.

Details

Reviewers

jrtc27
emaste

Commits

rG3b073d2ee50c: tools/build: Always bootstrap (sys/)bitstring.h

Summary

Older, supported FreeBSD versions lack bit_ntest() so hoist the boostrap
installation out of the OS!=FreeBSD case and always install it. A more
precise criteria is possible, but would add little value.

This fixes bootstrapping makefs as a build tool on 13.1.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48959
Build 45848: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 4 2023, 11:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 4 2023, 11:38 PM

brooks requested review of this revision.Jan 4 2023, 11:38 PM

Harbormaster completed remote builds in B48959: Diff 114762.Jan 4 2023, 11:38 PM

brooks added reviewers: jrtc27, emaste.Jan 4 2023, 11:39 PM

emaste accepted this revision.Jan 9 2023, 5:09 PM

This revision is now accepted and ready to land.Jan 9 2023, 5:09 PM

Should always be backwards-compatible so shouldn't be an issue to always have the newest version

Closed by commit rG3b073d2ee50c: tools/build: Always bootstrap (sys/)bitstring.h (authored by brooks). · Explain WhyJan 9 2023, 7:18 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG3b073d2ee50c: tools/build: Always bootstrap (sys/)bitstring.h.

Revision Contents
Changeset List

Path

Size

tools/

build/

Makefile

10 lines

Diff 114762

View Options

tools/build: Always bootstrap (sys/)bitstring.hClosedPublicActions