stand: Allow stand.h to be included in C++ programs
ClosedPublic
Actions

Authored by imp on Jan 4 2023, 8:11 PM.

Details

Reviewers

manu
kevans
jrtc27

Commits

rG5e4f201c7ded: stand: Allow stand.h to be included in C++ programs
rG5cf20707ba79: stand: Allow stand.h to be included in C++ programs

Summary

Allow stand.h to be included in C++ programs. This is little more than
using our stylized BEGIN_DECL / END_DECL around the entire
file. There's no run-time support for C++, so the C++ that can be used
is quite limited. It is enough for libunwind, though.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 4 2023, 8:11 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 4 2023, 8:11 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jan 4 2023, 8:11 PM

Harbormaster completed remote builds in B48953: Diff 114755.Jan 4 2023, 8:11 PM

imp added reviewers: kevans, jrtc27.Jan 4 2023, 8:12 PM

jrtc27 added inline comments.Jan 4 2023, 8:23 PM

stand/libsa/stand.h
65	Doing it around other headers is a bit gross

move.

Harbormaster completed remote builds in B48954: Diff 114756.Jan 4 2023, 8:29 PM

imp added inline comments.Jan 4 2023, 8:29 PM

stand/libsa/stand.h
65	Indeed. I'll move this lower in the file.... but __BEGIN_DECLS is designed to nest :)

imp added inline comments.Jan 4 2023, 8:30 PM

stand/libsa/stand.h
95	This is before the first structure that defines function pointers... Not ideal, but this file isn't well structured to limit its scope.

jrtc27 added inline comments.Jan 4 2023, 8:33 PM

stand/libsa/stand.h
65	It does, until you have something that really is a C++ symbol... which isn't relevant here, and almost never comes up, but better to separate "us vs them", as it were...