Page MenuHomeFreeBSD

linuxkpi: Include `linux/sched/mm.h` from `linux/sched.h`
ClosedPublic

Authored by dumbbell on Dec 30 2022, 10:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 27, 1:27 AM
Unknown Object (File)
May 4 2024, 2:41 AM
Unknown Object (File)
Apr 30 2024, 6:48 PM
Unknown Object (File)
Mar 6 2024, 3:02 AM
Unknown Object (File)
Feb 18 2024, 9:06 AM
Unknown Object (File)
Jan 20 2024, 3:25 AM
Unknown Object (File)
Dec 23 2023, 1:00 AM
Unknown Object (File)
Dec 12 2023, 6:31 AM

Details

Summary

At least one file in the DRM drivers benefits from some namespace pollution to use fs_reclaim_acquire()/fs_reclaim_release(). They are defined in linux/sched/mm.h and this header must be included indirectly into the DRM drivers' source file.

I couldn't find how it was included. Therefore this commit includes linux/sched/mm.h from linux/sched.h. This is not the case in Linux but fixes the issue with the DRM drivers.

This is part of the update of the DRM drivers to Linux 5.13.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Re-upload patch with context.

Maybe it will be easier/less problematic to include sched/mm.h in the problematic file in drm-kmod.

In D37912#861928, @manu wrote:

Maybe it will be easier/less problematic to include sched/mm.h in the problematic file in drm-kmod.

In fact, I did the same in D38154 (merged). I admit I would prefer to keep the problem where it is, in linuxkpi :-)

This revision is now accepted and ready to land.Jan 26 2023, 12:14 PM