Page MenuHomeFreeBSD
Differential D37894

atf_pytest_wrapper: Avoid truncation when longer output
ClosedPublic
Actions

Authored by jlduran on Dec 28 2022, 4:01 PM.
Tags
None
Referenced Files
F132569401: D37894.id114610.diff
Sat, Oct 18, 1:36 AM
Unknown Object (File)
Fri, Oct 17, 7:12 PM
Unknown Object (File)
Wed, Oct 15, 5:17 AM
Unknown Object (File)
Mon, Oct 13, 1:41 AM
Unknown Object (File)
Sun, Oct 12, 1:58 PM
Unknown Object (File)
Sun, Oct 12, 1:58 PM
Unknown Object (File)
Sun, Oct 12, 1:58 PM
Unknown Object (File)
Sun, Oct 12, 2:57 AM
View All 91 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
melifaro
Commits
rGa28a4cb5e909: atf_pytest_wrapper: fix pytest output truncation
rG058ac3e80633: atf_pytest_wrapper: fix pytest output truncation
Summary

When debugging a failure with longer output, the lines get truncated.
Pass -vv to pytest in order to get the full output.
While here, enforce the modeline.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Dec 28 2022, 4:01 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2022, 4:01 PM
jlduran requested review of this revision.Dec 28 2022, 4:01 PM
jlduran added a comment.Dec 28 2022, 4:04 PM

@melifaro, do you take GitHub pull requests? This review was originally two commits, one for the style fixes, another for the actual "fix".
I believe it is safe to leave always with -vv?, as it matches the other ATF output.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 28 2022, 5:34 PM
Closed by commit rG058ac3e80633: atf_pytest_wrapper: fix pytest output truncation (authored by jlduran, committed by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG058ac3e80633: atf_pytest_wrapper: fix pytest output truncation.
melifaro added a comment.Dec 28 2022, 5:38 PM

Thank you for the patch!

In D37894#860943, @jlduran_gmail.com wrote:

@melifaro, do you take GitHub pull requests? This review was originally two commits, one for the style fixes, another for the actual "fix".

Just in case - it's possible to create a review with multiple commits.

I believe it is safe to leave always with -vv?, as it matches the other ATF output.

I'm not sure I have the notifications configured, but let's try.

melifaro added a commit: rGa28a4cb5e909: atf_pytest_wrapper: fix pytest output truncation.Feb 9 2023, 4:12 PM

Revision Contents
Changeset List

PathSize
libexec/
atf/
atf-pytest-wrapper/
55 lines

Diff 114610

View Options

libexec/atf/atf-pytest-wrapper/atf_pytest_wrapper.cpp

Loading...